QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-18 23:55:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: enforce more ruff rules (#31447)

Browse Source 
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
This commit is contained in:
Maxime Beauchemin
2024-12-18 17:41:34 -08:00
committed by GitHub
parent 9da65d6bfd
commit e51b95ffa8
375 changed files with 1821 additions and 1718 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
tests/integration_tests/security_tests.py
View File

@@ -1191,7 +1191,7 @@ class TestRolePermission(SupersetTestCase):
delete_schema_perm("[examples].[1]")
def test_schemas_accessible_by_user_datasource_access(self):
# User has schema access to the datasource temp_schema.wb_health_population in examples DB.
# User has schema access to the datasource temp_schema.wb_health_population in examples DB. # noqa: E501
database = get_example_database()
with self.client.application.test_request_context():
with override_user(security_manager.find_user("gamma")):
@@ -1201,7 +1201,7 @@ class TestRolePermission(SupersetTestCase):
assert schemas == {"temp_schema"}
def test_schemas_accessible_by_user_datasource_and_schema_access(self):
# User has schema access to the datasource temp_schema.wb_health_population in examples DB.
# User has schema access to the datasource temp_schema.wb_health_population in examples DB. # noqa: E501
create_schema_perm("[examples].[2]")
with self.client.application.test_request_context():
database = get_example_database()
@@ -1286,7 +1286,7 @@ class TestRolePermission(SupersetTestCase):
"page": 0,
"page_size": -1,
}
NEW_FLASK_GET_SQL_DBS_REQUEST = f"/api/v1/database/?q={prison.dumps(arguments)}"
NEW_FLASK_GET_SQL_DBS_REQUEST = f"/api/v1/database/?q={prison.dumps(arguments)}" # noqa: N806
self.login(GAMMA_USERNAME)
databases_json = self.client.get(NEW_FLASK_GET_SQL_DBS_REQUEST).json
assert databases_json["count"] == 1
@@ -1616,7 +1616,7 @@ class TestSecurityManager(SupersetTestCase):
mock_can_access_schema.return_value = False
mock_is_owner.return_value = False
with self.assertRaises(SupersetSecurityException):
with self.assertRaises(SupersetSecurityException): # noqa: PT027
security_manager.raise_for_access(datasource=datasource)
@patch("superset.security.SupersetSecurityManager.is_owner")
@@ -1635,12 +1635,12 @@ class TestSecurityManager(SupersetTestCase):
mock_can_access.return_value = False
mock_is_owner.return_value = False
with self.assertRaises(SupersetSecurityException):
with self.assertRaises(SupersetSecurityException): # noqa: PT027
security_manager.raise_for_access(query=query)
def test_raise_for_access_sql_fails(self):
with override_user(security_manager.find_user("gamma")):
with self.assertRaises(SupersetSecurityException):
with self.assertRaises(SupersetSecurityException): # noqa: PT027
security_manager.raise_for_access(
database=get_example_database(),
schema="bar",
@@ -1672,7 +1672,7 @@ class TestSecurityManager(SupersetTestCase):
mock_can_access_schema.return_value = False
mock_is_owner.return_value = False
with override_user(security_manager.find_user("gamma")):
with self.assertRaises(SupersetSecurityException):
with self.assertRaises(SupersetSecurityException): # noqa: PT027
security_manager.raise_for_access(query_context=query_context)
@patch("superset.security.SupersetSecurityManager.can_access")
@@ -1685,7 +1685,7 @@ class TestSecurityManager(SupersetTestCase):
mock_can_access.return_value = False
with self.assertRaises(SupersetSecurityException):
with self.assertRaises(SupersetSecurityException): # noqa: PT027
security_manager.raise_for_access(database=database, table=table)
@patch("superset.security.SupersetSecurityManager.is_owner")
@@ -1703,7 +1703,7 @@ class TestSecurityManager(SupersetTestCase):
mock_can_access_schema.return_value = False
mock_is_owner.return_value = False
with override_user(security_manager.find_user("gamma")):
with self.assertRaises(SupersetSecurityException):
with self.assertRaises(SupersetSecurityException): # noqa: PT027
security_manager.raise_for_access(viz=test_viz)
@pytest.mark.usefixtures("load_birth_names_dashboard_with_slices")
@@ -1748,7 +1748,7 @@ class TestSecurityManager(SupersetTestCase):
births.roles = []
# No dashboard roles.
with self.assertRaises(SupersetSecurityException):
with self.assertRaises(SupersetSecurityException): # noqa: PT027
security_manager.raise_for_access(
**{
kwarg: Mock(
@@ -1764,7 +1764,7 @@ class TestSecurityManager(SupersetTestCase):
births.roles = [self.get_role("Gamma")]
# Undefined dashboard.
with self.assertRaises(SupersetSecurityException):
with self.assertRaises(SupersetSecurityException): # noqa: PT027
security_manager.raise_for_access(
**{
kwarg: Mock(
@@ -1775,7 +1775,7 @@ class TestSecurityManager(SupersetTestCase):
)
# Undefined dashboard chart.
with self.assertRaises(SupersetSecurityException):
with self.assertRaises(SupersetSecurityException): # noqa: PT027
security_manager.raise_for_access(
**{
kwarg: Mock(
@@ -1786,7 +1786,7 @@ class TestSecurityManager(SupersetTestCase):
)
# Ill-defined dashboard chart.
with self.assertRaises(SupersetSecurityException):
with self.assertRaises(SupersetSecurityException): # noqa: PT027
security_manager.raise_for_access(
**{
kwarg: Mock(
@@ -1800,7 +1800,7 @@ class TestSecurityManager(SupersetTestCase):
)
# Dashboard chart not associated with said datasource.
with self.assertRaises(SupersetSecurityException):
with self.assertRaises(SupersetSecurityException): # noqa: PT027
security_manager.raise_for_access(
**{
kwarg: Mock(
@@ -1827,7 +1827,7 @@ class TestSecurityManager(SupersetTestCase):
)
# Ill-defined native filter.
with self.assertRaises(SupersetSecurityException):
with self.assertRaises(SupersetSecurityException): # noqa: PT027
security_manager.raise_for_access(
**{
kwarg: Mock(
@@ -1841,7 +1841,7 @@ class TestSecurityManager(SupersetTestCase):
)
# Native filter not associated with said datasource.
with self.assertRaises(SupersetSecurityException):
with self.assertRaises(SupersetSecurityException): # noqa: PT027
security_manager.raise_for_access(
**{
kwarg: Mock(
@@ -2055,7 +2055,7 @@ class TestGuestTokens(SupersetTestCase):
guest_user = security_manager.get_guest_user_from_request(fake_request)
assert guest_user is None
self.assertRaisesRegex(ValueError, "Guest token does not contain a user claim")
self.assertRaisesRegex(ValueError, "Guest token does not contain a user claim") # noqa: PT027
def test_get_guest_user_no_resource(self):
user = {"username": "test_guest"}
@@ -2066,7 +2066,7 @@ class TestGuestTokens(SupersetTestCase):
fake_request.headers[current_app.config["GUEST_TOKEN_HEADER_NAME"]] = token
security_manager.get_guest_user_from_request(fake_request)
self.assertRaisesRegex(
self.assertRaisesRegex( # noqa: PT027
ValueError, "Guest token does not contain a resources claim"
)
@@ -2095,7 +2095,7 @@ class TestGuestTokens(SupersetTestCase):
guest_user = security_manager.get_guest_user_from_request(fake_request)
assert guest_user is None
self.assertRaisesRegex(ValueError, "This is not a guest token.")
self.assertRaisesRegex(ValueError, "This is not a guest token.") # noqa: PT027
def test_get_guest_user_bad_audience(self):
now = time.time()
@@ -2121,7 +2121,7 @@ class TestGuestTokens(SupersetTestCase):
fake_request.headers[current_app.config["GUEST_TOKEN_HEADER_NAME"]] = token
guest_user = security_manager.get_guest_user_from_request(fake_request)
self.assertRaisesRegex(jwt.exceptions.InvalidAudienceError, "Invalid audience")
self.assertRaisesRegex(jwt.exceptions.InvalidAudienceError, "Invalid audience") # noqa: PT027
assert guest_user is None
@patch("superset.security.SupersetSecurityManager._get_current_epoch_time")