QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-18 07:35:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: enforce more ruff rules (#31447)

Browse Source 
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
This commit is contained in:
Maxime Beauchemin
2024-12-18 17:41:34 -08:00
committed by GitHub
parent 9da65d6bfd
commit e51b95ffa8
375 changed files with 1821 additions and 1718 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
tests/unit_tests/commands/databases/create_test.py
View File

@@ -25,7 +25,7 @@ from superset.exceptions import OAuth2RedirectError
from superset.extensions import security_manager
@pytest.fixture()
@pytest.fixture
def database_with_catalog(mocker: MockerFixture) -> MagicMock:
"""
Mock a database with catalogs and schemas.
@@ -42,13 +42,13 @@ def database_with_catalog(mocker: MockerFixture) -> MagicMock:
{"schema3", "schema4"},
]
DatabaseDAO = mocker.patch("superset.commands.database.create.DatabaseDAO")
DatabaseDAO = mocker.patch("superset.commands.database.create.DatabaseDAO") # noqa: N806
DatabaseDAO.create.return_value = database
return database
@pytest.fixture()
@pytest.fixture
def database_without_catalog(mocker: MockerFixture) -> MagicMock:
"""
Mock a database without catalogs.
@@ -61,7 +61,7 @@ def database_without_catalog(mocker: MockerFixture) -> MagicMock:
database.db_engine_spec.supports_catalog = False
database.get_all_schema_names.return_value = ["schema1", "schema2"]
DatabaseDAO = mocker.patch("superset.commands.database.create.DatabaseDAO")
DatabaseDAO = mocker.patch("superset.commands.database.create.DatabaseDAO") # noqa: N806
DatabaseDAO.create.return_value = database
return database
@@ -134,7 +134,7 @@ def test_create_with_oauth2(
"""
Test that the database can be created even if OAuth2 is needed to connect.
"""
TestConnectionDatabaseCommand = mocker.patch(
TestConnectionDatabaseCommand = mocker.patch( # noqa: N806
"superset.commands.database.create.TestConnectionDatabaseCommand"
)
TestConnectionDatabaseCommand().run.side_effect = OAuth2RedirectError(