chore: enforce more ruff rules (#31447)

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
This commit is contained in:
Maxime Beauchemin
2024-12-18 17:41:34 -08:00
committed by GitHub
parent 9da65d6bfd
commit e51b95ffa8
375 changed files with 1821 additions and 1718 deletions

View File

@@ -19,7 +19,7 @@ from __future__ import annotations
import pickle
from datetime import datetime, timedelta
from typing import Generator, TYPE_CHECKING
from typing import TYPE_CHECKING
from uuid import UUID
import pytest
@@ -54,7 +54,7 @@ NEW_VALUE = {"foo": "baz"}
@pytest.fixture
def key_value_entry() -> Generator[KeyValueEntry, None, None]:
def key_value_entry() -> KeyValueEntry:
from superset.key_value.models import KeyValueEntry
entry = KeyValueEntry(
@@ -65,7 +65,7 @@ def key_value_entry() -> Generator[KeyValueEntry, None, None]:
)
db.session.add(entry)
db.session.flush()
yield entry
return entry
def test_create_id_entry(
@@ -143,7 +143,7 @@ def test_create_pickle_entry(
found_entry = (
db.session.query(KeyValueEntry).filter_by(id=created_entry.id).one()
)
assert isinstance(pickle.loads(found_entry.value), type(PICKLE_VALUE))
assert isinstance(pickle.loads(found_entry.value), type(PICKLE_VALUE)) # noqa: S301
assert found_entry.created_by_fk == admin_user.id