QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 08:04:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: enforce more ruff rules (#31447)

Browse Source 
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
This commit is contained in:
Maxime Beauchemin
2024-12-18 17:41:34 -08:00
committed by GitHub
parent 9da65d6bfd
commit e51b95ffa8
375 changed files with 1821 additions and 1718 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tests/unit_tests/explore/api_test.py
View File

@@ -24,5 +24,5 @@ def test_explore_datasource_not_found(client: Any, full_api_access: None) -> Non
response = client.get(
"/api/v1/explore/?datasource_id=50000&datasource_type=table",
)
response.json["result"]["dataset"]["name"] == "[Missing Dataset]"
response.json["result"]["dataset"]["name"] == "[Missing Dataset]" # noqa: B015
assert response.status_code == 200

14
tests/unit_tests/explore/utils_test.py
View File

@@ -15,7 +15,7 @@
# specific language governing permissions and limitations
# under the License.
from flask_appbuilder.security.sqla.models import User
from pytest import raises
from pytest import raises # noqa: PT013
from pytest_mock import MockerFixture
from superset.commands.chart.exceptions import (
@@ -63,7 +63,7 @@ def test_unsaved_chart_no_dataset_id() -> None:
def test_unsaved_chart_unknown_dataset_id(mocker: MockerFixture) -> None:
from superset.explore.utils import check_access as check_chart_access
with raises(DatasetNotFoundError):
with raises(DatasetNotFoundError): # noqa: PT012
mocker.patch(dataset_find_by_id, return_value=None)
with override_user(User()):
@@ -77,7 +77,7 @@ def test_unsaved_chart_unknown_dataset_id(mocker: MockerFixture) -> None:
def test_unsaved_chart_unknown_query_id(mocker: MockerFixture) -> None:
from superset.explore.utils import check_access as check_chart_access
with raises(QueryNotFoundValidationError):
with raises(QueryNotFoundValidationError): # noqa: PT012
mocker.patch(query_find_by_id, return_value=None)
with override_user(User()):
@@ -92,7 +92,7 @@ def test_unsaved_chart_unauthorized_dataset(mocker: MockerFixture) -> None:
from superset.connectors.sqla.models import SqlaTable
from superset.explore.utils import check_access as check_chart_access
with raises(DatasetAccessDeniedError):
with raises(DatasetAccessDeniedError): # noqa: PT012
mocker.patch(dataset_find_by_id, return_value=SqlaTable())
mocker.patch(can_access_datasource, return_value=False)
@@ -123,7 +123,7 @@ def test_saved_chart_unknown_chart_id(mocker: MockerFixture) -> None:
from superset.connectors.sqla.models import SqlaTable
from superset.explore.utils import check_access as check_chart_access
with raises(ChartNotFoundError):
with raises(ChartNotFoundError): # noqa: PT012
mocker.patch(dataset_find_by_id, return_value=SqlaTable())
mocker.patch(can_access_datasource, return_value=True)
mocker.patch(chart_find_by_id, return_value=None)
@@ -140,7 +140,7 @@ def test_saved_chart_unauthorized_dataset(mocker: MockerFixture) -> None:
from superset.connectors.sqla.models import SqlaTable
from superset.explore.utils import check_access as check_chart_access
with raises(DatasetAccessDeniedError):
with raises(DatasetAccessDeniedError): # noqa: PT012
mocker.patch(dataset_find_by_id, return_value=SqlaTable())
mocker.patch(can_access_datasource, return_value=False)
@@ -214,7 +214,7 @@ def test_saved_chart_no_access(mocker: MockerFixture) -> None:
from superset.explore.utils import check_access as check_chart_access
from superset.models.slice import Slice
with raises(ChartAccessDeniedError):
with raises(ChartAccessDeniedError): # noqa: PT012
mocker.patch(dataset_find_by_id, return_value=SqlaTable())
mocker.patch(can_access_datasource, return_value=True)
mocker.patch(is_admin, return_value=False)