chore: enforce more ruff rules (#31447)

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

tests/unit_tests/utils/date_parser_tests.py

@@ -38,7 +38,7 @@ from superset.utils.date_parser import (
 from tests.unit_tests.conftest import with_feature_flags
 
 
-def mock_parse_human_datetime(s: str) -> Optional[datetime]:
+def mock_parse_human_datetime(s: str) -> Optional[datetime]:  # noqa: C901
     if s == "now":
         return datetime(2016, 11, 7, 9, 30, 10)
     elif s == "2018":
@@ -230,7 +230,7 @@ def test_get_since_until() -> None:
     expected = datetime(1999, 12, 25), datetime(2017, 12, 25)
     assert result == expected
 
-    with pytest.raises(ValueError):
+    with pytest.raises(ValueError):  # noqa: PT011
         get_since_until(time_range="tomorrow : yesterday")
 
 
@@ -420,12 +420,12 @@ def test_datetime_eval() -> None:
     assert result == -9
 
     result = datetime_eval(
-        "datediff(datetime('2018-01-01T00:00:00'), datetime('2018-01-10T00:00:00'), day)"  # pylint: disable=line-too-long,useless-suppression
+        "datediff(datetime('2018-01-01T00:00:00'), datetime('2018-01-10T00:00:00'), day)"  # pylint: disable=line-too-long,useless-suppression  # noqa: E501
     )
     assert result == 9
 
     result = datetime_eval(
-        "datediff(datetime('2018-01-01T00:00:00'), datetime('2018-01-10T00:00:00'), year)"  # pylint: disable=line-too-long,useless-suppression
+        "datediff(datetime('2018-01-01T00:00:00'), datetime('2018-01-10T00:00:00'), year)"  # pylint: disable=line-too-long,useless-suppression  # noqa: E501
     )
     assert result == 0
 

tests/unit_tests/utils/json_tests.py

@@ -183,7 +183,7 @@ def test_sensitive_fields() -> None:
     }
 
     new_payload = copy.deepcopy(redacted_payload)
-    new_payload["credentials"]["user_token"] = "NEW_TOKEN"
+    new_payload["credentials"]["user_token"] = "NEW_TOKEN"  # noqa: S105
 
     assert json.reveal_sensitive(payload, new_payload, sensitive_fields) == {
         "password": "SECRET",

tests/unit_tests/utils/oauth2_tests.py

@@ -43,7 +43,7 @@ def test_get_oauth2_access_token_base_token_valid(mocker: MockerFixture) -> None
     db = mocker.patch("superset.utils.oauth2.db")
     db_engine_spec = mocker.MagicMock()
     token = mocker.MagicMock()
-    token.access_token = "access-token"
+    token.access_token = "access-token"  # noqa: S105
     token.access_token_expiration = datetime(2024, 1, 2)
     db.session.query().filter_by().one_or_none.return_value = token
 
@@ -62,16 +62,16 @@ def test_get_oauth2_access_token_base_refresh(mocker: MockerFixture) -> None:
         "expires_in": 3600,
     }
     token = mocker.MagicMock()
-    token.access_token = "access-token"
+    token.access_token = "access-token"  # noqa: S105
     token.access_token_expiration = datetime(2024, 1, 1)
-    token.refresh_token = "refresh-token"
+    token.refresh_token = "refresh-token"  # noqa: S105
     db.session.query().filter_by().one_or_none.return_value = token
 
     with freeze_time("2024-01-02"):
         assert get_oauth2_access_token({}, 1, 1, db_engine_spec) == "new-token"
 
     # check that token was updated
-    assert token.access_token == "new-token"
+    assert token.access_token == "new-token"  # noqa: S105
     assert token.access_token_expiration == datetime(2024, 1, 2, 1)
     db.session.add.assert_called_with(token)
 
@@ -83,7 +83,7 @@ def test_get_oauth2_access_token_base_no_refresh(mocker: MockerFixture) -> None:
     db = mocker.patch("superset.utils.oauth2.db")
     db_engine_spec = mocker.MagicMock()
     token = mocker.MagicMock()
-    token.access_token = "access-token"
+    token.access_token = "access-token"  # noqa: S105
     token.access_token_expiration = datetime(2024, 1, 1)
     token.refresh_token = None
     db.session.query().filter_by().one_or_none.return_value = token

tests/unit_tests/utils/test_core.py

@@ -220,7 +220,7 @@ def test_check_if_safe_zip_success(app_context: None) -> None:
     """
     Test if ZIP files are safe
     """
-    ZipFile = MagicMock()
+    ZipFile = MagicMock()  # noqa: N806
     ZipFile.infolist.return_value = [
         MockZipInfo(file_size=1000, compress_size=10),
         MockZipInfo(file_size=1000, compress_size=10),
@@ -235,7 +235,7 @@ def test_check_if_safe_zip_high_rate(app_context: None) -> None:
     """
     Test if ZIP files is not highly compressed
     """
-    ZipFile = MagicMock()
+    ZipFile = MagicMock()  # noqa: N806
     ZipFile.infolist.return_value = [
         MockZipInfo(file_size=1000, compress_size=1),
         MockZipInfo(file_size=1000, compress_size=1),
@@ -251,7 +251,7 @@ def test_check_if_safe_zip_hidden_bomb(app_context: None) -> None:
     """
     Test if ZIP file does not contain a big file highly compressed
     """
-    ZipFile = MagicMock()
+    ZipFile = MagicMock()  # noqa: N806
     ZipFile.infolist.return_value = [
         MockZipInfo(file_size=1000, compress_size=100),
         MockZipInfo(file_size=1000, compress_size=100),