QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 08:04:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor sql_json view endpoint: separate concern into ad hod method (#16595)

Browse Source
This commit is contained in:
ofekisr
2021-09-05 23:18:17 +03:00
committed by GitHub
parent be77ad2288
commit e60b489867
3 changed files with 17 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
superset/utils/sqllab_execution_context.py
View File

@@ -105,7 +105,7 @@ class SqlJsonExecutionContext: # pylint: disable=too-many-instance-attributes
limit = 0
return limit
def _get_user_id(self) -> Optional[int]: # pylint: disable=R0201
def _get_user_id(self) -> Optional[int]: # pylint: disable=no-self-use
try:
return g.user.get_id() if g.user else None
except RuntimeError:
@@ -135,7 +135,7 @@ class SqlJsonExecutionContext: # pylint: disable=too-many-instance-attributes
pass
def create_query(self) -> Query:
# pylint: disable=C0301
# pylint: disable=line-too-long
start_time = now_as_float()
if self.select_as_cta:
return Query(
@@ -167,7 +167,7 @@ class SqlJsonExecutionContext: # pylint: disable=too-many-instance-attributes
)
class CreateTableAsSelect: # pylint: disable=R0903
class CreateTableAsSelect: # pylint: disable=too-few-public-methods
ctas_method: CtasMethod
target_schema_name: Optional[str]
target_table_name: str