QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 08:04:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: [dashboard] should not trigger chart refresh when filter not applicable (#9891)

Browse Source 
* fix: [dashboard][filter] should not trigger chart refresh when filter is not applicable

* fix comments
This commit is contained in:
Grace Guo
2020-05-26 10:14:12 -07:00
committed by GitHub
parent 7f6dbf838e
commit e6a55d8858
2 changed files with 102 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files

70
superset-frontend/spec/javascripts/dashboard/components/Dashboard_spec.jsx
View File

@@ -62,10 +62,10 @@ describe('Dashboard', () => {
// activeFilters map use id_column) as key
const OVERRIDE_FILTERS = {
'1_region': [],
'2_country_name': ['USA'],
'3_region': [],
'3_country_name': ['USA'],
'1_region': { values: [], scope: [1] },
'2_country_name': { values: ['USA'], scope: [1, 2] },
'3_region': { values: [], scope: [1] },
'3_country_name': { values: ['USA'], scope: [] },
};
it('should render a DashboardBuilder', () => {
@@ -143,19 +143,13 @@ describe('Dashboard', () => {
it('should call refresh if a filter is added', () => {
const newFilter = {
gender: ['boy', 'girl'],
gender: { values: ['boy', 'girl'], scope: [1] },
};
wrapper.setProps({
activeFilters: {
...OVERRIDE_FILTERS,
...newFilter,
},
activeFilters: newFilter,
});
expect(refreshSpy.callCount).toBe(1);
expect(wrapper.instance().appliedFilters).toEqual({
...OVERRIDE_FILTERS,
...newFilter,
});
expect(wrapper.instance().appliedFilters).toEqual(newFilter);
});
it('should call refresh if a filter is removed', () => {
@@ -167,17 +161,55 @@ describe('Dashboard', () => {
});
it('should call refresh if a filter is changed', () => {
const newFilters = {
...OVERRIDE_FILTERS,
'1_region': { values: ['Canada'], scope: [1] },
};
wrapper.setProps({
activeFilters: {
...OVERRIDE_FILTERS,
'1_region': ['Canada'],
},
activeFilters: newFilters,
});
expect(refreshSpy.callCount).toBe(1);
expect(wrapper.instance().appliedFilters).toEqual({
expect(wrapper.instance().appliedFilters).toEqual(newFilters);
expect(refreshSpy.getCall(0).args[0]).toEqual([1]);
});
it('should call refresh with multiple chart ids', () => {
const newFilters = {
...OVERRIDE_FILTERS,
'1_region': ['Canada'],
'2_country_name': { values: ['New Country'], scope: [1, 2] },
};
wrapper.setProps({
activeFilters: newFilters,
});
expect(refreshSpy.callCount).toBe(1);
expect(wrapper.instance().appliedFilters).toEqual(newFilters);
expect(refreshSpy.getCall(0).args[0]).toEqual([1, 2]);
});
it('should call refresh if a filter scope is changed', () => {
const newFilters = {
...OVERRIDE_FILTERS,
'3_country_name': { values: ['USA'], scope: [2] },
};
wrapper.setProps({
activeFilters: newFilters,
});
expect(refreshSpy.callCount).toBe(1);
expect(refreshSpy.getCall(0).args[0]).toEqual([2]);
});
it('should call refresh with empty [] if a filter is changed but scope is not applicable', () => {
const newFilters = {
...OVERRIDE_FILTERS,
'3_country_name': { values: ['CHINA'], scope: [] },
};
wrapper.setProps({
activeFilters: newFilters,
});
expect(refreshSpy.callCount).toBe(1);
expect(refreshSpy.getCall(0).args[0]).toEqual([]);
});
});
});