fix: refactor view error handling into a separate module (#29330)

This commit is contained in:
Maxime Beauchemin
2024-07-09 10:16:40 -07:00
committed by GitHub
parent 3d0665183c
commit e749efcb97
9 changed files with 236 additions and 206 deletions

View File

@@ -23,7 +23,7 @@ from datetime import datetime
from typing import Any, Callable, cast
from urllib import parse
from flask import abort, flash, g, redirect, render_template, request, Response
from flask import abort, flash, g, redirect, request, Response
from flask_appbuilder import expose
from flask_appbuilder.security.decorators import (
has_access,
@@ -85,11 +85,10 @@ from superset.views.base import (
data_payload_response,
deprecated,
generate_download_headers,
get_error_msg,
handle_api_exception,
json_error_response,
json_success,
)
from superset.views.error_handling import handle_api_exception
from superset.views.utils import (
bootstrap_user_data,
check_datasource_perms,
@@ -888,13 +887,6 @@ class Superset(BaseSupersetView):
datasource.raise_for_access()
return json_success(json.dumps(sanitize_datasource_data(datasource.data)))
@app.errorhandler(500)
def show_traceback(self) -> FlaskResponse:
return (
render_template("superset/traceback.html", error_msg=get_error_msg()),
500,
)
@event_logger.log_this
@expose("/welcome/")
def welcome(self) -> FlaskResponse: