From e85337c5439c8a4590952557071cc7df69b7a0dc Mon Sep 17 00:00:00 2001 From: Joe Li Date: Tue, 23 Sep 2025 10:49:28 -0700 Subject: [PATCH] fix(docs): escape comparison operators in MDX files to resolve build errors (#35185) Co-authored-by: Claude Co-authored-by: Sam Firke --- docs/docs/configuration/alerts-reports.mdx | 4 ++-- docs/docs/configuration/theming.mdx | 2 +- docs/docs/contributing/guidelines.mdx | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/docs/configuration/alerts-reports.mdx b/docs/docs/configuration/alerts-reports.mdx index 5f4f0289574..8123954086a 100644 --- a/docs/docs/configuration/alerts-reports.mdx +++ b/docs/docs/configuration/alerts-reports.mdx @@ -36,11 +36,11 @@ Screenshots will be taken but no messages actually sent as long as `ALERT_REPORT #### In your `Dockerfile` You'll need to extend the Superset image to include a headless browser. Your options include: -- Use Playwright with Chrome: this is the recommended approach as of version >=4.1.x. A working example of a Dockerfile that installs these tools is provided under “Building your own production Docker image” on the [Docker Builds](/docs/installation/docker-builds#building-your-own-production-docker-image) page. Read the code comments there as you'll also need to change a feature flag in your config. +- Use Playwright with Chrome: this is the recommended approach as of version 4.1.x or greater. A working example of a Dockerfile that installs these tools is provided under "Building your own production Docker image" on the [Docker Builds](/docs/installation/docker-builds#building-your-own-production-docker-image) page. Read the code comments there as you'll also need to change a feature flag in your config. - Use Firefox: you'll need to install geckodriver and Firefox. - Use Chrome without Playwright: you'll need to install Chrome and set the value of `WEBDRIVER_TYPE` to `"chrome"` in your `superset_config.py`. -In Superset versions <=4.0x, users installed Firefox or Chrome and that was documented here. +In Superset versions prior to 4.1, users installed Firefox or Chrome and that was documented here. Only the worker container needs the browser. diff --git a/docs/docs/configuration/theming.mdx b/docs/docs/configuration/theming.mdx index e37d4eb0274..3f8e31c08c3 100644 --- a/docs/docs/configuration/theming.mdx +++ b/docs/docs/configuration/theming.mdx @@ -7,7 +7,7 @@ version: 1 # Theming Superset :::note -apache-superset>=6.0 +`apache-superset>=6.0` ::: Superset now rides on **Ant Design v5's token-based theming**. diff --git a/docs/docs/contributing/guidelines.mdx b/docs/docs/contributing/guidelines.mdx index 1ba1e6af93c..de734eebd75 100644 --- a/docs/docs/contributing/guidelines.mdx +++ b/docs/docs/contributing/guidelines.mdx @@ -130,7 +130,7 @@ Committers may also update title to reflect the issue/PR content if the author-p If the PR passes CI tests and does not have any `need:` labels, it is ready for review, add label `review` and/or `design-review`. -If an issue/PR has been inactive for >=30 days, it will be closed. If it does not have any status label, add `inactive`. +If an issue/PR has been inactive for at least 30 days, it will be closed. If it does not have any status label, add `inactive`. When creating a PR, if you're aiming to have it included in a specific release, please tag it with the version label. For example, to have a PR considered for inclusion in Superset 1.1 use the label `v1.1`.