QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-20 00:24:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: optimize mapStateToProps for chart controls (#10264)

Browse Source
This commit is contained in:
Jesse Yang
2020-07-09 00:33:48 -07:00
committed by GitHub
parent 8d9bb5f472
commit e94c9804a2
6 changed files with 63 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
superset-frontend/spec/javascripts/explore/controlUtils_spec.jsx
View File

@@ -27,6 +27,7 @@ import {
getFormDataFromControls,
applyMapStateToPropsToControl,
getAllControlsState,
getControlsState,
} from 'src/explore/controlUtils';
describe('controlUtils', () => {
@@ -246,6 +247,14 @@ describe('controlUtils', () => {
const control = getControlState('metrics', 'table', stateWithCount);
expect(control.default).toEqual(['count']);
});
it('should not apply mapStateToProps when initializing', () => {
const control = getControlState('metrics', 'table', {
...state,
isInitializing: true,
});
expect(control.default).toEqual(null);
});
});
describe('validateControl', () => {