QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 08:04:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: pass all properties to validate_parameters (#21487)

Browse Source
This commit is contained in:
Elizabeth Thompson
2022-10-03 17:48:54 -07:00
committed by GitHub
parent 4417c6e3e2
commit e98943e580
11 changed files with 109 additions and 74 deletions
Download Patch File Download Diff File Expand all files Collapse all files

72
tests/integration_tests/db_engine_specs/base_engine_spec_tests.py
View File

@@ -421,28 +421,32 @@ def test_validate(is_port_open, is_hostname_valid):
is_hostname_valid.return_value = True
is_port_open.return_value = True
parameters = {
"host": "localhost",
"port": 5432,
"username": "username",
"password": "password",
"database": "dbname",
"query": {"sslmode": "verify-full"},
properties = {
"parameters": {
"host": "localhost",
"port": 5432,
"username": "username",
"password": "password",
"database": "dbname",
"query": {"sslmode": "verify-full"},
}
}
errors = BasicParametersMixin.validate_parameters(parameters)
errors = BasicParametersMixin.validate_parameters(properties)
assert errors == []
def test_validate_parameters_missing():
parameters = {
"host": "",
"port": None,
"username": "",
"password": "",
"database": "",
"query": {},
properties = {
"parameters": {
"host": "",
"port": None,
"username": "",
"password": "",
"database": "",
"query": {},
}
}
errors = BasicParametersMixin.validate_parameters(parameters)
errors = BasicParametersMixin.validate_parameters(properties)
assert errors == [
SupersetError(
message=(
@@ -459,15 +463,17 @@ def test_validate_parameters_missing():
def test_validate_parameters_invalid_host(is_hostname_valid):
is_hostname_valid.return_value = False
parameters = {
"host": "localhost",
"port": None,
"username": "username",
"password": "password",
"database": "dbname",
"query": {"sslmode": "verify-full"},
properties = {
"parameters": {
"host": "localhost",
"port": None,
"username": "username",
"password": "password",
"database": "dbname",
"query": {"sslmode": "verify-full"},
}
}
errors = BasicParametersMixin.validate_parameters(parameters)
errors = BasicParametersMixin.validate_parameters(properties)
assert errors == [
SupersetError(
message="One or more parameters are missing: port",
@@ -490,15 +496,17 @@ def test_validate_parameters_port_closed(is_port_open, is_hostname_valid):
is_hostname_valid.return_value = True
is_port_open.return_value = False
parameters = {
"host": "localhost",
"port": 5432,
"username": "username",
"password": "password",
"database": "dbname",
"query": {"sslmode": "verify-full"},
properties = {
"parameters": {
"host": "localhost",
"port": 5432,
"username": "username",
"password": "password",
"database": "dbname",
"query": {"sslmode": "verify-full"},
}
}
errors = BasicParametersMixin.validate_parameters(parameters)
errors = BasicParametersMixin.validate_parameters(properties)
assert errors == [
SupersetError(
message="The port is closed.",