refactor(db): use Dialect instead of Engine in select_star to avoid SSH tunnels (#35540)

Co-authored-by: Claude <noreply@anthropic.com>

tests/unit_tests/db_engine_specs/test_base.py

@@ -227,13 +227,12 @@ def test_select_star(mocker: MockerFixture) -> None:
         query.compile(dialect=sqlite.dialect())
     )
 
-    engine = mocker.MagicMock()
-    engine.dialect = sqlite.dialect()
+    dialect = sqlite.dialect()
 
     sql = BaseEngineSpec.select_star(
         database=database,
         table=Table("my_table", "my_schema", "my_catalog"),
-        engine=engine,
+        dialect=dialect,
         limit=100,
         show_cols=True,
         indent=True,

tests/unit_tests/db_engine_specs/test_bigquery.py

@@ -154,13 +154,12 @@ def test_select_star(mocker: MockerFixture) -> None:
         query.compile(dialect=BigQueryDialect(), compile_kwargs={"literal_binds": True})
     )
 
-    engine = mocker.MagicMock()
-    engine.dialect = BigQueryDialect()
+    dialect = BigQueryDialect()
 
     sql = BigQueryEngineSpec.select_star(
         database=database,
         table=Table("my_table"),
-        engine=engine,
+        dialect=dialect,
         limit=100,
         show_cols=True,
         indent=True,

tests/unit_tests/db_engine_specs/test_hive.py

@@ -71,7 +71,7 @@ def test_select_star(mocker: MockerFixture) -> None:
     from superset.db_engine_specs.hive import HiveEngineSpec
 
     database = mocker.MagicMock()
-    engine = mocker.MagicMock()
+    dialect = mocker.MagicMock()
 
     def quote_table(table: Table, dialect: Dialect) -> str:
         return ".".join(
@@ -83,7 +83,7 @@ def test_select_star(mocker: MockerFixture) -> None:
     HiveEngineSpec.select_star(
         database=database,
         table=Table("my_table", "my_schema", "my_catalog"),
-        engine=engine,
+        dialect=dialect,
         limit=100,
         show_cols=False,
         indent=True,

tests/unit_tests/db_engine_specs/test_postgres.py

@@ -252,7 +252,7 @@ def test_select_star(mocker: MockerFixture) -> None:
     Test the ``select_star`` method.
     """
     database = mocker.MagicMock()
-    engine = mocker.MagicMock()
+    dialect = mocker.MagicMock()
 
     def quote_table(table: Table, dialect: Dialect) -> str:
         return ".".join(
@@ -264,7 +264,7 @@ def test_select_star(mocker: MockerFixture) -> None:
     spec.select_star(
         database=database,
         table=Table("my_table", "my_schema", "my_catalog"),
-        engine=engine,
+        dialect=dialect,
         limit=100,
         show_cols=False,
         indent=True,

tests/unit_tests/db_engine_specs/test_presto.py

@@ -314,7 +314,7 @@ def test_select_star(mocker: MockerFixture) -> None:
     from superset.db_engine_specs.presto import PrestoEngineSpec as spec  # noqa: N813
 
     database = mocker.MagicMock()
-    engine = mocker.MagicMock()
+    dialect = mocker.MagicMock()
 
     def quote_table(table: Table, dialect: Dialect) -> str:
         return ".".join(
@@ -326,7 +326,7 @@ def test_select_star(mocker: MockerFixture) -> None:
     spec.select_star(
         database=database,
         table=Table("my_table", "my_schema", "my_catalog"),
-        engine=engine,
+        dialect=dialect,
         limit=100,
         show_cols=False,
         indent=True,