QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-05-28 11:15:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

Simplify function signature

Browse Source
This commit is contained in:
Beto Dealmeida
2026-05-08 14:28:21 -04:00
parent 0fe8293c7f
commit e9dd9a6107
4 changed files with 24 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
tests/unit_tests/models/test_virtual_dataset_format.py
View File

@@ -209,7 +209,7 @@ class TestApplyRlsReturnValue:
from superset.utils.rls import apply_rls
database = MagicMock()
database.db_engine_spec.get_rls_method.return_value = MagicMock()
database.db_engine_spec.rls_method = RLSMethod.AS_SUBQUERY
database.get_default_catalog.return_value = None
statement = MagicMock()
@@ -237,7 +237,7 @@ class TestApplyRlsReturnValue:
mock_get_predicates.return_value = []
database = MagicMock()
database.db_engine_spec.get_rls_method.return_value = MagicMock()
database.db_engine_spec.rls_method = RLSMethod.AS_SUBQUERY
database.get_default_catalog.return_value = None
mock_table = MagicMock()
@@ -268,7 +268,7 @@ class TestApplyRlsReturnValue:
mock_get_predicates.return_value = ["user_id = 42"]
database = MagicMock()
database.db_engine_spec.get_rls_method.return_value = MagicMock()
database.db_engine_spec.rls_method = RLSMethod.AS_SUBQUERY
database.get_default_catalog.return_value = None
mock_table = MagicMock()
@@ -276,8 +276,6 @@ class TestApplyRlsReturnValue:
statement = MagicMock()
statement.tables = [mock_table]
statement.parse_predicate.return_value = MagicMock()
result = apply_rls(
database=database,
catalog=None,
@@ -312,11 +310,10 @@ class TestRLSSubqueryAlias:
"""
sql = "SELECT pens.pen_id, pens.is_green FROM public.pens"
statement = SQLStatement(sql, engine="redshift")
predicate = statement.parse_predicate("user_id = 1")
statement.apply_rls(
None,
"public",
{Table("pens", "public", None): [predicate]},
{Table("pens", "public", None): ["user_id = 1"]},
RLSMethod.AS_SUBQUERY,
)
result = statement.format()
@@ -333,11 +330,10 @@ class TestRLSSubqueryAlias:
"""
sql = "SELECT pens.pen_id, pens.is_green FROM mycat.public.pens"
statement = SQLStatement(sql, engine="redshift")
predicate = statement.parse_predicate("user_id = 1")
statement.apply_rls(
None,
"public",
{Table("pens", "public", "mycat"): [predicate]},
{Table("pens", "public", "mycat"): ["user_id = 1"]},
RLSMethod.AS_SUBQUERY,
)
result = statement.format()
@@ -351,11 +347,10 @@ class TestRLSSubqueryAlias:
"""
sql = "SELECT p.pen_id, p.is_green FROM public.pens p"
statement = SQLStatement(sql, engine="redshift")
predicate = statement.parse_predicate("user_id = 1")
statement.apply_rls(
None,
"public",
{Table("pens", "public", None): [predicate]},
{Table("pens", "public", None): ["user_id = 1"]},
RLSMethod.AS_SUBQUERY,
)
result = statement.format()
@@ -369,11 +364,10 @@ class TestRLSSubqueryAlias:
"""
sql = "SELECT pen_id, is_green FROM public.pens"
statement = SQLStatement(sql, engine="redshift")
predicate = statement.parse_predicate("user_id = 1")
statement.apply_rls(
None,
"public",
{Table("pens", "public", None): [predicate]},
{Table("pens", "public", None): ["user_id = 1"]},
RLSMethod.AS_SUBQUERY,
)
result = statement.format()