QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-21 00:54:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(explore): fix clearing select data causes popover dismiss (#14221)

Browse Source 
* fix(explore): fix clearing select data causes popover dismiss

* wip: lint

* wip: lint
This commit is contained in:
Yaozong Liu
2021-05-20 22:26:27 +08:00
committed by GitHub
parent a9d888ad40
commit ea37274180
3 changed files with 65 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
superset-frontend/src/explore/components/controls/SelectControl.jsx
View File

@@ -105,7 +105,7 @@ export default class SelectControl extends React.PureComponent {
// Beware: This is acting like an on-click instead of an on-change
// (firing every time user chooses vs firing only if a new option is chosen).
onChange(opt) {
onChange(opt, actionMeta) {
let optionValue = this.props.multi ? [] : null;
if (opt) {
if (this.props.multi) {
@@ -126,7 +126,7 @@ export default class SelectControl extends React.PureComponent {
}
}
// will eventually call `exploreReducer`: SET_FIELD_VALUE
this.props.onChange(optionValue);
this.props.onChange(optionValue, [], actionMeta);
}
getSelectRef(instance) {