From ea64f3122e2e5c8d6f9b67b4629020baa0053895 Mon Sep 17 00:00:00 2001 From: Kasia <36897697+kasiazjc@users.noreply.github.com> Date: Thu, 31 Jul 2025 21:04:33 +0200 Subject: [PATCH] chore: Change button labels to sentence case (#34432) Co-authored-by: Claude --- .../FiltersConfigModal/FilterConfigPane.test.tsx | 6 +++--- .../nativeFilters/FiltersConfigModal/FilterTitlePane.tsx | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterConfigPane.test.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterConfigPane.test.tsx index 4511f5dc428..2c5cc0618c3 100644 --- a/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterConfigPane.test.tsx +++ b/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterConfigPane.test.tsx @@ -96,14 +96,14 @@ test('remove filter', async () => { test('add filter', async () => { defaultRender(); // First trash icon - const addFilterButton = await screen.findByText('Add Filter'); + const addFilterButton = await screen.findByText('Add filter'); userEvent.click(addFilterButton); expect(defaultProps.onAdd).toHaveBeenCalledWith('NATIVE_FILTER'); }); test('add divider', async () => { defaultRender(); - const addFilterButton = await screen.findByText('Add Divider'); + const addFilterButton = await screen.findByText('Add divider'); userEvent.click(addFilterButton); expect(defaultProps.onAdd).toHaveBeenCalledWith('DIVIDER'); }); @@ -128,7 +128,7 @@ test('filter container should scroll to bottom when adding items', async () => { defaultRender(state, props); - const addFilterButton = await screen.findByText('Add Filter'); + const addFilterButton = await screen.findByText('Add filter'); userEvent.click(addFilterButton); diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterTitlePane.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterTitlePane.tsx index 8b1b32e017d..f78bcfbc64a 100644 --- a/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterTitlePane.tsx +++ b/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterTitlePane.tsx @@ -111,7 +111,7 @@ const FilterTitlePane: FC = ({ data-test="add-new-filter-button" onClick={() => handleOnAdd(NativeFilterType.NativeFilter)} > - {t('Add Filter')} + {t('Add filter')}