QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-08-12 11:11:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(mcp): sanitize chart config errors and accept field name aliases (#39606)

Browse Source 
(cherry picked from commit ad20285dd6)
This commit is contained in:
Amin Ghadersohi
2026-04-29 09:12:55 -07:00
committed by Joe Li
parent 5a6cd8f6db
commit ea91ae1d03
9 changed files with 269 additions and 93 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/unit_tests/mcp_service/chart/tool/test_update_chart.py
+4 -4
View File
@@ -609,7 +609,7 @@ class TestBuildUpdatePayload:
chart = Mock()
chart.datasource_id = None # Avoid dataset lookup
result = _build_update_payload(request, chart)
result = _build_update_payload(request, chart, parsed_config=config)
assert isinstance(result, dict)
assert result["slice_name"] == "My Custom Name"
@@ -627,7 +627,7 @@ class TestBuildUpdatePayload:
chart.datasource_id = None
chart.slice_name = "Existing Name"
result = _build_update_payload(request, chart)
result = _build_update_payload(request, chart, parsed_config=config)
assert isinstance(result, dict)
assert result["slice_name"] == "Existing Name"
@@ -861,7 +861,7 @@ class TestBuildPreviewFormData:
chart.slice_name = "Existing"
chart.params = '{"viz_type": "line", "custom_flag": true}'
result = _build_preview_form_data(request, chart)
result = _build_preview_form_data(request, chart, parsed_config=config)
assert isinstance(result, dict)
# Existing keys not touched by the new config are preserved
@@ -918,7 +918,7 @@ class TestBuildPreviewFormData:
chart.slice_name = "Broken"
chart.params = "not-json"
result = _build_preview_form_data(request, chart)
result = _build_preview_form_data(request, chart, parsed_config=config)
assert isinstance(result, dict)
assert result["slice_id"] == 9