QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-05-12 19:35:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(chart): add feature flag that displays the data pane closes by default (#21649)

Browse Source
This commit is contained in:
Victor Arbues
2022-10-05 08:34:03 +01:00
committed by GitHub
parent 50cb396bf2
commit ebd75366c0
5 changed files with 32 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
superset-frontend/src/explore/components/DataTablesPane/DataTablesPane.tsx
View File

@@ -26,6 +26,7 @@ import React, {
import { styled, t, useTheme } from '@superset-ui/core';
import Icons from 'src/components/Icons';
import Tabs from 'src/components/Tabs';
import { FeatureFlag, isFeatureEnabled } from 'src/featureFlags';
import {
getItem,
setItem,
@@ -96,11 +97,14 @@ export const DataTablesPane = ({
samples: false,
});
const [panelOpen, setPanelOpen] = useState(
getItem(LocalStorageKeys.is_datapanel_open, false),
isFeatureEnabled(FeatureFlag.DATAPANEL_CLOSED_BY_DEFAULT)
? false
: getItem(LocalStorageKeys.is_datapanel_open, false),
);
useEffect(() => {
setItem(LocalStorageKeys.is_datapanel_open, panelOpen);
if (!isFeatureEnabled(FeatureFlag.DATAPANEL_CLOSED_BY_DEFAULT))
setItem(LocalStorageKeys.is_datapanel_open, panelOpen);
}, [panelOpen]);
useEffect(() => {

17
superset-frontend/src/explore/components/DataTablesPane/test/DataTablesPane.test.tsx
View File

@@ -19,12 +19,14 @@
import React from 'react';
import userEvent from '@testing-library/user-event';
import fetchMock from 'fetch-mock';
import { FeatureFlag } from 'src/featureFlags';
import * as copyUtils from 'src/utils/copy';
import {
render,
screen,
waitForElementToBeRemoved,
} from 'spec/helpers/testing-library';
import { setItem, LocalStorageKeys } from 'src/utils/localStorageHelpers';
import { DataTablesPane } from '..';
import { createDataTablesPaneProps } from './fixture';
@@ -143,4 +145,19 @@ describe('DataTablesPane', () => {
expect(screen.queryByText('Action')).not.toBeInTheDocument();
fetchMock.restore();
});
test('Displaying the data pane is under featureflag', () => {
// @ts-ignore
global.featureFlags = {
[FeatureFlag.DATAPANEL_CLOSED_BY_DEFAULT]: true,
};
const props = createDataTablesPaneProps(0);
setItem(LocalStorageKeys.is_datapanel_open, true);
render(<DataTablesPane {...props} />, {
useRedux: true,
});
expect(
screen.queryByLabelText('Collapse data panel'),
).not.toBeInTheDocument();
});
});