mirror of
https://github.com/apache/superset.git
synced 2026-04-19 08:04:53 +00:00
Relayout SQL Editor (#6872)
* Relayout SQL Editor - Refactor SQL editor to remove usage of bootstrap col, row and collapse to simplify the layout - Replace the react-split-pane libraray with react-split to allow custom styling of the gutter area without sacrifice correctness of the ace editor height calculation - Rewrite the left pane animation via plain css transition and animate it to slide in and out - General code and css clean up * Smooth out the visual transition during dragging (cherry picked from commit 19f82b729c7a939f12b1c5da6022c0fd76fa3ec9) * Adjust how the height of the south pane is computed, fixing cypress tests
This commit is contained in:
committed by
GitHub
parent
8302b9a276
commit
ec6657ab2d
@@ -24,7 +24,7 @@ import { shallow } from 'enzyme';
|
||||
|
||||
import { STATUS_OPTIONS } from '../../../src/SqlLab/constants';
|
||||
import { initialState } from './fixtures';
|
||||
import SouthPane from '../../../src/SqlLab/components/SouthPane';
|
||||
import SouthPaneContainer, { SouthPane } from '../../../src/SqlLab/components/SouthPane';
|
||||
|
||||
describe('SouthPane', () => {
|
||||
const middlewares = [thunk];
|
||||
@@ -42,11 +42,16 @@ describe('SouthPane', () => {
|
||||
};
|
||||
|
||||
const getWrapper = () => (
|
||||
shallow(<SouthPane {...mockedProps} />, {
|
||||
shallow(<SouthPaneContainer {...mockedProps} />, {
|
||||
context: { store },
|
||||
}).dive());
|
||||
|
||||
let wrapper;
|
||||
|
||||
beforeAll(() => {
|
||||
jest.spyOn(SouthPane.prototype, 'getSouthPaneHeight').mockImplementation(() => 500);
|
||||
});
|
||||
|
||||
it('should render offline when the state is offline', () => {
|
||||
wrapper = getWrapper();
|
||||
wrapper.setProps({ offline: true });
|
||||
|
||||
@@ -38,6 +38,11 @@ describe('SqlEditor', () => {
|
||||
defaultQueryLimit: 1000,
|
||||
maxRow: 100000,
|
||||
};
|
||||
|
||||
beforeAll(() => {
|
||||
jest.spyOn(SqlEditor.prototype, 'getSqlEditorHeight').mockImplementation(() => 500);
|
||||
});
|
||||
|
||||
it('is valid', () => {
|
||||
expect(
|
||||
React.isValidElement(<SqlEditor {...mockedProps} />),
|
||||
|
||||
Reference in New Issue
Block a user