From ec8177fe157d0db938b4ca9c0823dc82f69a5389 Mon Sep 17 00:00:00 2001 From: Amin Ghadersohi Date: Tue, 10 Mar 2026 19:09:09 +0100 Subject: [PATCH] fix(charts): set reasonable default y-axis title margin to prevent label overlap (#38389) Co-authored-by: Claude Opus 4.6 (cherry picked from commit fe7f220c210689cc9ccb5d4ab46456be6823a28f) --- .../src/Timeseries/EchartsTimeseries.test.tsx | 2 +- .../plugins/plugin-chart-echarts/src/Timeseries/constants.ts | 2 +- superset-frontend/plugins/plugin-chart-echarts/src/constants.ts | 2 +- .../test/MixedTimeseries/transformProps.test.ts | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/EchartsTimeseries.test.tsx b/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/EchartsTimeseries.test.tsx index b290596d153..4c52463936b 100644 --- a/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/EchartsTimeseries.test.tsx +++ b/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/EchartsTimeseries.test.tsx @@ -158,7 +158,7 @@ const defaultFormData: EchartsTimeseriesFormData & { xAxisTitle: '', xAxisTitleMargin: 0, yAxisTitle: '', - yAxisTitleMargin: 0, + yAxisTitleMargin: 15, yAxisTitlePosition: '', time_range: 'No filter', granularity: undefined, diff --git a/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/constants.ts b/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/constants.ts index c07be715216..472d5fc6525 100644 --- a/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/constants.ts +++ b/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/constants.ts @@ -46,7 +46,7 @@ export const DEFAULT_FORM_DATA: EchartsTimeseriesFormData = { xAxisTitle: '', xAxisTitleMargin: 0, yAxisTitle: '', - yAxisTitleMargin: 0, + yAxisTitleMargin: 15, yAxisTitlePosition: 'Top', // Now that the weird bug workaround is over, here's the rest... ...DEFAULT_SORT_SERIES_DATA, diff --git a/superset-frontend/plugins/plugin-chart-echarts/src/constants.ts b/superset-frontend/plugins/plugin-chart-echarts/src/constants.ts index 286f611e6d3..76de9217868 100644 --- a/superset-frontend/plugins/plugin-chart-echarts/src/constants.ts +++ b/superset-frontend/plugins/plugin-chart-echarts/src/constants.ts @@ -104,7 +104,7 @@ export const DEFAULT_TITLE_FORM_DATA: TitleFormData = { xAxisTitle: '', xAxisTitleMargin: 0, yAxisTitle: '', - yAxisTitleMargin: 0, + yAxisTitleMargin: 15, yAxisTitlePosition: 'Top', }; diff --git a/superset-frontend/plugins/plugin-chart-echarts/test/MixedTimeseries/transformProps.test.ts b/superset-frontend/plugins/plugin-chart-echarts/test/MixedTimeseries/transformProps.test.ts index f17924ec66e..e8707d0c8c2 100644 --- a/superset-frontend/plugins/plugin-chart-echarts/test/MixedTimeseries/transformProps.test.ts +++ b/superset-frontend/plugins/plugin-chart-echarts/test/MixedTimeseries/transformProps.test.ts @@ -112,7 +112,7 @@ const formData: EchartsMixedTimeseriesFormData = { yAxisBounds: [undefined, undefined], yAxisBoundsSecondary: [undefined, undefined], yAxisTitle: '', - yAxisTitleMargin: 0, + yAxisTitleMargin: 15, yAxisTitlePosition: '', yAxisTitleSecondary: '', zoomable: false,