QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-07 18:35:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: keep modal open when saving database failed (#11618)

Browse Source
This commit is contained in:
Jesse Yang
2020-11-12 16:10:14 -08:00
committed by GitHub
parent 3ad65bc163
commit ec8ccd4cf1
10 changed files with 142 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
tests/databases/api_tests.py
View File

@@ -289,17 +289,9 @@ class TestDatabaseApi(SupersetTestCase):
rv = self.client.post(uri, json=database_data)
response = json.loads(rv.data.decode("utf-8"))
self.assertEqual(rv.status_code, 400)
expected_response = {
"message": {
"sqlalchemy_uri": [
"Invalid connection string, a valid string usually "
"follows:'DRIVER://USER:PASSWORD@DB-HOST/DATABASE-NAME'"
"<p>Example:'postgresql://user:password@your-postgres-db/database'"
"</p>"
]
}
}
self.assertEqual(response, expected_response)
self.assertIn(
"Invalid connection string", response["message"]["sqlalchemy_uri"][0],
)
def test_create_database_fail_sqllite(self):
"""
@@ -447,17 +439,9 @@ class TestDatabaseApi(SupersetTestCase):
rv = self.client.put(uri, json=database_data)
response = json.loads(rv.data.decode("utf-8"))
self.assertEqual(rv.status_code, 400)
expected_response = {
"message": {
"sqlalchemy_uri": [
"Invalid connection string, a valid string usually "
"follows:'DRIVER://USER:PASSWORD@DB-HOST/DATABASE-NAME'"
"<p>Example:'postgresql://user:password@your-postgres-db/database'"
"</p>"
]
}
}
self.assertEqual(response, expected_response)
self.assertIn(
"Invalid connection string", response["message"]["sqlalchemy_uri"][0],
)
def test_delete_database(self):
"""