QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 16:14:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: enable metadata sync for virtual tables (#10645)

Browse Source 
* feat: enable metadata sync for virtual tables

* add migration and check for empty schema name

* simplify request

* truncate trailing column attributes for MySQL

* add unit test

* use db_engine_spec func to truncate collation and charset

* Remove redundant migration

* add more tests

* address review comments and apply templating to query

* add todo for refactoring

* remove schema from tests

* check column datatype
This commit is contained in:
Ville Brofeldt
2020-10-27 07:58:38 +02:00
committed by GitHub
parent 8575439f48
commit ecdff724ea
5 changed files with 139 additions and 76 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tests/import_export_tests.py
View File

@@ -113,7 +113,7 @@ class TestImportExport(SupersetTestCase):
json_metadata=json.dumps(json_metadata),
)
def create_table(self, name, schema="", id=0, cols_names=[], metric_names=[]):
def create_table(self, name, schema=None, id=0, cols_names=[], metric_names=[]):
params = {"remote_id": id, "database_name": "examples"}
table = SqlaTable(
id=id, schema=schema, table_name=name, params=json.dumps(params)