mirror of
https://github.com/apache/superset.git
synced 2026-04-20 00:24:38 +00:00
chore(dao): Replace save/overwrite with create/update respectively (#24467)
This commit is contained in:
@@ -44,7 +44,7 @@ class CreateDatasetCommand(CreateMixin, BaseCommand):
|
||||
self.validate()
|
||||
try:
|
||||
# Creates SqlaTable (Dataset)
|
||||
dataset = DatasetDAO.create(self._properties, commit=False)
|
||||
dataset = DatasetDAO.create(attributes=self._properties, commit=False)
|
||||
|
||||
# Updates columns and metrics from the datase
|
||||
dataset.fetch_metadata(commit=False)
|
||||
|
||||
@@ -66,8 +66,8 @@ class UpdateDatasetCommand(UpdateMixin, BaseCommand):
|
||||
if self._model:
|
||||
try:
|
||||
dataset = DatasetDAO.update(
|
||||
model=self._model,
|
||||
properties=self._properties,
|
||||
self._model,
|
||||
attributes=self._properties,
|
||||
)
|
||||
return dataset
|
||||
except DAOUpdateFailedError as ex:
|
||||
|
||||
Reference in New Issue
Block a user