chore(dao): Replace save/overwrite with create/update respectively (#24467)

This commit is contained in:
John Bodley
2023-08-11 12:55:39 -07:00
committed by GitHub
parent a3d72e0ec7
commit ed0d288ccd
22 changed files with 196 additions and 194 deletions

View File

@@ -44,7 +44,7 @@ class CreateDatasetCommand(CreateMixin, BaseCommand):
self.validate()
try:
# Creates SqlaTable (Dataset)
dataset = DatasetDAO.create(self._properties, commit=False)
dataset = DatasetDAO.create(attributes=self._properties, commit=False)
# Updates columns and metrics from the datase
dataset.fetch_metadata(commit=False)

View File

@@ -66,8 +66,8 @@ class UpdateDatasetCommand(UpdateMixin, BaseCommand):
if self._model:
try:
dataset = DatasetDAO.update(
model=self._model,
properties=self._properties,
self._model,
attributes=self._properties,
)
return dataset
except DAOUpdateFailedError as ex: