QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-20 00:24:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

Allow resizing width of SQL Lab left bar / editor (#8099)

Browse Source 
* wip

* Finish PR

* Remove annoying snap

* Fix lint

* Fix js tests
This commit is contained in:
Beto Dealmeida
2019-08-26 10:07:47 -07:00
committed by GitHub
parent 7ac1a290eb
commit ed3360b135
5 changed files with 76 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
superset/assets/spec/javascripts/sqllab/SqlEditor_spec.jsx
View File

@@ -21,8 +21,8 @@ import { shallow } from 'enzyme';
import { defaultQueryEditor, initialState, queries, table } from './fixtures';
import {
SQL_EDITOR_GUTTER_HEIGHT,
SQL_EDITOR_GUTTER_MARGIN,
SQL_EDITOR_VERTICAL_GUTTER_HEIGHT,
SQL_EDITOR_VERTICAL_GUTTER_MARGIN,
SQL_TOOLBAR_HEIGHT,
} from '../../../src/SqlLab/constants';
import AceEditorWrapper from '../../../src/SqlLab/components/AceEditorWrapper';
@@ -73,8 +73,8 @@ describe('SqlEditor', () => {
const totalSize = parseFloat(wrapper.find(AceEditorWrapper).props().height)
+ wrapper.find(SouthPane).props().height
+ SQL_TOOLBAR_HEIGHT
+ (SQL_EDITOR_GUTTER_MARGIN * 2)
+ SQL_EDITOR_GUTTER_HEIGHT;
+ (SQL_EDITOR_VERTICAL_GUTTER_MARGIN * 2)
+ SQL_EDITOR_VERTICAL_GUTTER_HEIGHT;
expect(totalSize).toEqual(MOCKED_SQL_EDITOR_HEIGHT);
});
it('does not overflow the editor window after resizing', () => {
@@ -83,8 +83,8 @@ describe('SqlEditor', () => {
const totalSize = parseFloat(wrapper.find(AceEditorWrapper).props().height)
+ wrapper.find(SouthPane).props().height
+ SQL_TOOLBAR_HEIGHT
+ (SQL_EDITOR_GUTTER_MARGIN * 2)
+ SQL_EDITOR_GUTTER_HEIGHT;
+ (SQL_EDITOR_VERTICAL_GUTTER_MARGIN * 2)
+ SQL_EDITOR_VERTICAL_GUTTER_HEIGHT;
expect(totalSize).toEqual(450);
});
it('render a LimitControl with default limit', () => {