From ed4eefa6de28042f1420b45a573d3602a136857d Mon Sep 17 00:00:00 2001 From: Evan Rusackas Date: Thu, 23 Apr 2026 01:38:03 -0700 Subject: [PATCH] fix(lint): drop unused labelsColor/labelsColorMap/cacheBusterProp destructuring Commit 08aac73 ("address review: replace side-effect useMemo with idiomatic hooks") removed the shouldComponentUpdate-style useMemo that was the only consumer of these three props, but left them in the destructuring block. This caused TS6133 "declared but never read" errors in lint-frontend (tsc --noEmit). Drop the destructuring; the props remain declared on the ChartRendererProps interface so the component's public API is unchanged. --- superset-frontend/src/components/Chart/ChartRenderer.tsx | 3 --- 1 file changed, 3 deletions(-) diff --git a/superset-frontend/src/components/Chart/ChartRenderer.tsx b/superset-frontend/src/components/Chart/ChartRenderer.tsx index f8b81694b7b..d0d85812287 100644 --- a/superset-frontend/src/components/Chart/ChartRenderer.tsx +++ b/superset-frontend/src/components/Chart/ChartRenderer.tsx @@ -200,8 +200,6 @@ function ChartRendererComponent({ datasource, formData, latestQueryFormData, - labelsColor, - labelsColorMap, height, width, vizType: propVizType, @@ -214,7 +212,6 @@ function ChartRendererComponent({ postTransformProps, source, emitCrossFilters, - cacheBusterProp, onChartStateChange, } = restProps;