mirror of
https://github.com/apache/superset.git
synced 2026-04-20 16:44:46 +00:00
Require the SQLAlchemy URI on the database model (#8720)
* Require the SQLAlchemy URI when creating a database * Add migration to make dbs.sqlalchemy_uri not-nullable * Fixes for black, isort, tests * Alter migration to use current revision from master as downgrade target * Update tests to support new db constraint * black
This commit is contained in:
committed by
Maxime Beauchemin
parent
a96eae46af
commit
ed54f6ec8d
@@ -228,6 +228,7 @@ class SupersetTestCase(TestCase):
|
||||
cls=models.Database,
|
||||
criteria={"database_name": database_name},
|
||||
session=db.session,
|
||||
sqlalchemy_uri="sqlite://test",
|
||||
id=db_id,
|
||||
extra=extra,
|
||||
)
|
||||
|
||||
@@ -316,7 +316,9 @@ class RolePermissionTests(SupersetTestCase):
|
||||
|
||||
def test_set_perm_database(self):
|
||||
session = db.session
|
||||
database = Database(database_name="tmp_database")
|
||||
database = Database(
|
||||
database_name="tmp_database", sqlalchemy_uri="sqlite://test"
|
||||
)
|
||||
session.add(database)
|
||||
|
||||
stored_db = (
|
||||
@@ -346,7 +348,9 @@ class RolePermissionTests(SupersetTestCase):
|
||||
|
||||
def test_set_perm_slice(self):
|
||||
session = db.session
|
||||
database = Database(database_name="tmp_database")
|
||||
database = Database(
|
||||
database_name="tmp_database", sqlalchemy_uri="sqlite://test"
|
||||
)
|
||||
table = SqlaTable(table_name="tmp_perm_table", database=database)
|
||||
session.add(database)
|
||||
session.add(table)
|
||||
|
||||
Reference in New Issue
Block a user