QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-06-02 06:09:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(Menu): Upgrade Menu Component to Ant Design 5 (#31699)

Browse Source 
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
This commit is contained in:
Geido
2025-01-21 19:06:53 +01:00
committed by GitHub
parent 550123882c
commit eec374426f
54 changed files with 984 additions and 1379 deletions
Download Patch File Download Diff File Expand all files Collapse all files

67
superset-frontend/src/explore/components/useExploreAdditionalActionsMenu/DashboardsSubMenu.test.tsx
View File

@@ -21,57 +21,58 @@ import userEvent from '@testing-library/user-event';
import { Menu } from 'src/components/Menu';
import DashboardItems from './DashboardsSubMenu';
const asyncRender = (numberOfItems: number) =>
waitFor(() => {
const dashboards = [];
for (let i = 1; i <= numberOfItems; i += 1) {
dashboards.push({ id: i, dashboard_title: `Dashboard ${i}` });
}
render(
<Menu openKeys={['menu']}>
<Menu.SubMenu title="On dashboards" key="menu">
<DashboardItems key="menu" dashboards={dashboards} />
</Menu.SubMenu>
</Menu>,
{
useRouter: true,
},
);
});
const asyncRender = (numberOfItems: number) => {
const dashboards = [];
for (let i = 1; i <= numberOfItems; i += 1) {
dashboards.push({ id: i, dashboard_title: `Dashboard ${i}` });
}
render(
<Menu openKeys={['menu']}>
<Menu.SubMenu title="On dashboards" key="menu">
<DashboardItems key="menu" dashboards={dashboards} />
</Menu.SubMenu>
</Menu>,
{
useRouter: true,
},
);
};
test('renders a submenu', async () => {
await asyncRender(3);
expect(screen.getByText('Dashboard 1')).toBeInTheDocument();
expect(screen.getByText('Dashboard 2')).toBeInTheDocument();
expect(screen.getByText('Dashboard 3')).toBeInTheDocument();
asyncRender(3);
await waitFor(() => {
expect(screen.getByText('Dashboard 1')).toBeInTheDocument();
expect(screen.getByText('Dashboard 2')).toBeInTheDocument();
expect(screen.getByText('Dashboard 3')).toBeInTheDocument();
});
});
test('renders a submenu with search', async () => {
await asyncRender(20);
expect(screen.getByPlaceholderText('Search')).toBeInTheDocument();
asyncRender(20);
expect(await screen.findByPlaceholderText('Search')).toBeInTheDocument();
});
test('displays a searched value', async () => {
await asyncRender(20);
asyncRender(20);
userEvent.type(screen.getByPlaceholderText('Search'), '2');
expect(screen.getByText('Dashboard 2')).toBeInTheDocument();
expect(screen.getByText('Dashboard 20')).toBeInTheDocument();
expect(await screen.findByText('Dashboard 2')).toBeInTheDocument();
expect(await screen.findByText('Dashboard 20')).toBeInTheDocument();
});
test('renders a "No results found" message when searching', async () => {
await asyncRender(20);
asyncRender(20);
userEvent.type(screen.getByPlaceholderText('Search'), 'unknown');
expect(screen.getByText('No results found')).toBeInTheDocument();
expect(await screen.findByText('No results found')).toBeInTheDocument();
});
test('renders a submenu with no dashboards', async () => {
await asyncRender(0);
expect(screen.getByText('None')).toBeInTheDocument();
asyncRender(0);
expect(await screen.findByText('None')).toBeInTheDocument();
});
test('shows link icon when hovering', async () => {
await asyncRender(3);
asyncRender(3);
expect(screen.queryByRole('img', { name: 'full' })).not.toBeInTheDocument();
userEvent.hover(screen.getByText('Dashboard 1'));
expect(screen.getByRole('img', { name: 'full' })).toBeInTheDocument();
userEvent.hover(await screen.findByText('Dashboard 1'));
expect(await screen.findByRole('img', { name: 'full' })).toBeInTheDocument();
});

4
superset-frontend/src/explore/components/useExploreAdditionalActionsMenu/index.jsx
View File

@@ -384,7 +384,7 @@ export const useExploreAdditionalActionsMenu = (
<Menu.Item key={MENU_KEYS.EMBED_CODE}>
<ModalTrigger
triggerNode={
<span data-test="embed-code-button">{t('Embed code')}</span>
<div data-test="embed-code-button">{t('Embed code')}</div>
}
modalTitle={t('Embed code')}
modalBody={
@@ -429,7 +429,7 @@ export const useExploreAdditionalActionsMenu = (
<Menu.Item key={MENU_KEYS.VIEW_QUERY}>
<ModalTrigger
triggerNode={
<span data-test="view-query-menu-item">{t('View query')}</span>
<div data-test="view-query-menu-item">{t('View query')}</div>
}
modalTitle={t('View query')}
modalBody={