QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 08:04:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

Using inheritance scheme to organize db specific code (#1294)

Browse Source 
* Using inheritance scheme to organize db specific code

* Addressing comments
This commit is contained in:
Maxime Beauchemin
2016-10-12 13:50:47 -07:00
committed by GitHub
parent 8626c80d3a
commit ef2670ca32
7 changed files with 248 additions and 133 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tests/core_tests.py
View File

@@ -130,8 +130,7 @@ class CoreTests(CaravelTestCase):
(slc.slice_name, 'slice_url', slc.slice_url),
(slc.slice_name, 'json_endpoint', slc.viz.json_endpoint),
(slc.slice_name, 'csv_endpoint', slc.viz.csv_endpoint),
(slc.slice_name, 'slice_id_url',
"/caravel/{slc.datasource_type}/{slc.datasource_id}/{slc.id}/".format(slc=slc)),
(slc.slice_name, 'slice_id_url', slc.slice_id_url),
]
for name, method, url in urls:
print("[{name}]/[{method}]: {url}".format(**locals()))
@@ -401,7 +400,6 @@ class CoreTests(CaravelTestCase):
resp = self.get_resp('/dashboardmodelview/list/')
assert "/caravel/dashboard/births/" in resp
print(self.get_resp('/caravel/dashboard/births/'))
assert 'Births' in self.get_resp('/caravel/dashboard/births/')
# Confirm that public doesn't have access to other datasets.