QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-08-12 11:11:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

remove --max-fail 1 on integration tests to iterate faster

Browse Source
This commit is contained in:
Maxime Beauchemin
2025-07-29 22:36:12 -07:00
parent 48d8c91b19
commit ef4cf2b430
6 changed files with 14 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scripts/python_tests.sh
+1 -1
View File
@@ -33,4 +33,4 @@ superset load-test-users
echo "Running tests" echo "Running tests"
pytest --durations-min=2 --maxfail=1 --cov-report= --cov=superset ./tests/integration_tests "$@" pytest --durations-min=2 --cov-report= --cov=superset ./tests/integration_tests "$@"
tests/integration_tests/charts/api_tests.py
+2 -4
View File
@@ -1077,9 +1077,7 @@ class TestChartApi(ApiOwnersTestCaseMixin, InsertChartMixin, SupersetTestCase):
""" """
self.login(GAMMA_USERNAME) self.login(GAMMA_USERNAME)
chart_no_access = ( chart_no_access = (
db.session.query(Slice) db.session.query(Slice).filter_by(slice_name="Trends").one_or_none()
.filter_by(slice_name="Girl Name Cloud")
.one_or_none()
) )
uri = f"api/v1/chart/{chart_no_access.id}" uri = f"api/v1/chart/{chart_no_access.id}"
rv = self.client.get(uri) rv = self.client.get(uri)
@@ -2062,7 +2060,7 @@ class TestChartApi(ApiOwnersTestCaseMixin, InsertChartMixin, SupersetTestCase):
@pytest.mark.usefixtures("load_birth_names_dashboard_with_slices") @pytest.mark.usefixtures("load_birth_names_dashboard_with_slices")
def test_warm_up_cache_no_datasource(self) -> None: def test_warm_up_cache_no_datasource(self) -> None:
self.login(ADMIN_USERNAME) self.login(ADMIN_USERNAME)
slc = self.get_slice("Top 10 Girl Name Share") slc = self.get_slice("Genders")
with mock.patch.object( with mock.patch.object(
Slice, Slice,
tests/integration_tests/charts/commands_tests.py
+1 -1
View File
@@ -426,7 +426,7 @@ class TestChartWarmUpCacheCommand(SupersetTestCase):
@pytest.mark.usefixtures("load_birth_names_dashboard_with_slices") @pytest.mark.usefixtures("load_birth_names_dashboard_with_slices")
@pytest.mark.skip(reason="This test will be changed to use the api/v1/data") @pytest.mark.skip(reason="This test will be changed to use the api/v1/data")
def test_warm_up_cache(self): def test_warm_up_cache(self):
slc = self.get_slice("Top 10 Girl Name Share") slc = self.get_slice("Genders")
result = ChartWarmUpCacheCommand(slc.id, None, None).run() result = ChartWarmUpCacheCommand(slc.id, None, None).run()
assert result == { assert result == {
"chart_id": slc.id, "chart_id": slc.id,
tests/integration_tests/core_tests.py
+1 -1
View File
@@ -227,7 +227,7 @@ class TestCore(SupersetTestCase):
def test_slice_data(self): def test_slice_data(self):
# slice data should have some required attributes # slice data should have some required attributes
self.login(ADMIN_USERNAME) self.login(ADMIN_USERNAME)
slc = self.get_slice(slice_name="Top 10 Girl Name Share") slc = self.get_slice(slice_name="Genders")
slc_data_attributes = slc.data.keys() slc_data_attributes = slc.data.keys()
assert "changed_on" in slc_data_attributes assert "changed_on" in slc_data_attributes
assert "modified" in slc_data_attributes assert "modified" in slc_data_attributes
tests/integration_tests/dashboards/api_tests.py
+5 -5
View File
@@ -1489,7 +1489,7 @@ class TestDashboardApi(ApiOwnersTestCaseMixin, InsertChartMixin, SupersetTestCas
"alpha2", "password", "Alpha", email="alpha2@superset.org" "alpha2", "password", "Alpha", email="alpha2@superset.org"
) )
existing_slice = ( existing_slice = (
db.session.query(Slice).filter_by(slice_name="Girl Name Cloud").first() db.session.query(Slice).filter_by(slice_name="Participants").first()
) )
dashboard = self.insert_dashboard( dashboard = self.insert_dashboard(
"title", "slug1", [user_alpha1.id], slices=[existing_slice], published=True "title", "slug1", [user_alpha1.id], slices=[existing_slice], published=True
@@ -1515,7 +1515,7 @@ class TestDashboardApi(ApiOwnersTestCaseMixin, InsertChartMixin, SupersetTestCas
"alpha2", "password", "Alpha", email="alpha2@superset.org" "alpha2", "password", "Alpha", email="alpha2@superset.org"
) )
existing_slice = ( existing_slice = (
db.session.query(Slice).filter_by(slice_name="Girl Name Cloud").first() db.session.query(Slice).filter_by(slice_name="Participants").first()
) )
dashboard_count = 4 dashboard_count = 4
@@ -1985,7 +1985,7 @@ class TestDashboardApi(ApiOwnersTestCaseMixin, InsertChartMixin, SupersetTestCas
admin = self.get_user("admin") admin = self.get_user("admin")
slices = [] slices = []
slices.append(db.session.query(Slice).filter_by(slice_name="Trends").one()) slices.append(db.session.query(Slice).filter_by(slice_name="Trends").one())
slices.append(db.session.query(Slice).filter_by(slice_name="Boys").one()) slices.append(db.session.query(Slice).filter_by(slice_name="Genders").one())
# Insert dashboard with admin as owner # Insert dashboard with admin as owner
dashboard = self.insert_dashboard( dashboard = self.insert_dashboard(
@@ -2016,7 +2016,7 @@ class TestDashboardApi(ApiOwnersTestCaseMixin, InsertChartMixin, SupersetTestCas
assert rv.status_code == 200 assert rv.status_code == 200
# Check that chart named Boys does not contain alpha 1 in its owners # Check that chart named Boys does not contain alpha 1 in its owners
boys = db.session.query(Slice).filter_by(slice_name="Boys").one() boys = db.session.query(Slice).filter_by(slice_name="Genders").one()
assert user_alpha1 not in boys.owners assert user_alpha1 not in boys.owners
# Revert owners on slice # Revert owners on slice
@@ -2223,7 +2223,7 @@ class TestDashboardApi(ApiOwnersTestCaseMixin, InsertChartMixin, SupersetTestCas
"alpha2", "password", "Alpha", email="alpha2@superset.org" "alpha2", "password", "Alpha", email="alpha2@superset.org"
) )
existing_slice = ( existing_slice = (
db.session.query(Slice).filter_by(slice_name="Girl Name Cloud").first() db.session.query(Slice).filter_by(slice_name="Participants").first()
) )
dashboard = self.insert_dashboard( dashboard = self.insert_dashboard(
"title", "slug1", [user_alpha1.id], slices=[existing_slice], published=True "title", "slug1", [user_alpha1.id], slices=[existing_slice], published=True
tests/integration_tests/dashboards/security/security_rbac_tests.py
+4 -4
View File
@@ -100,7 +100,7 @@ class TestDashboardRoleBasedSecurity(BaseTestDashboardSecurity):
self.create_user_with_roles(username, [new_role], should_create_roles=True) self.create_user_with_roles(username, [new_role], should_create_roles=True)
slice = ( slice = (
db.session.query(Slice) # noqa: F405 db.session.query(Slice) # noqa: F405
.filter_by(slice_name="Girl Name Cloud") .filter_by(slice_name="Participants")
.one_or_none() .one_or_none()
) )
dashboard_to_access = create_dashboard_to_db(published=True, slices=[slice]) dashboard_to_access = create_dashboard_to_db(published=True, slices=[slice])
@@ -141,7 +141,7 @@ class TestDashboardRoleBasedSecurity(BaseTestDashboardSecurity):
slice = ( slice = (
db.session.query(Slice) # noqa: F405 db.session.query(Slice) # noqa: F405
.filter_by(slice_name="Girl Name Cloud") .filter_by(slice_name="Participants")
.one_or_none() .one_or_none()
) )
dashboard = create_dashboard_to_db(published=True, slices=[slice]) dashboard = create_dashboard_to_db(published=True, slices=[slice])
@@ -164,7 +164,7 @@ class TestDashboardRoleBasedSecurity(BaseTestDashboardSecurity):
slice = ( slice = (
db.session.query(Slice) # noqa: F405 db.session.query(Slice) # noqa: F405
.filter_by(slice_name="Girl Name Cloud") .filter_by(slice_name="Participants")
.one_or_none() .one_or_none()
) )
dashboard = create_dashboard_to_db(published=True, slices=[slice]) dashboard = create_dashboard_to_db(published=True, slices=[slice])
@@ -192,7 +192,7 @@ class TestDashboardRoleBasedSecurity(BaseTestDashboardSecurity):
slice = ( slice = (
db.session.query(Slice) # noqa: F405 db.session.query(Slice) # noqa: F405
.filter_by(slice_name="Girl Name Cloud") .filter_by(slice_name="Participants")
.one_or_none() .one_or_none()
) )
dashboard_to_access = create_dashboard_to_db(published=True, slices=[slice]) dashboard_to_access = create_dashboard_to_db(published=True, slices=[slice])