QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 08:04:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Refactor ownership checks and ensure consistency (#20499)

Browse Source 
Co-authored-by: John Bodley <john.bodley@airbnb.com>
This commit is contained in:
John Bodley
2022-07-07 11:04:27 -07:00
committed by GitHub
parent e7b965a3b2
commit f0ca158989
107 changed files with 614 additions and 807 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
superset/explore/form_data/api.py
View File

@@ -16,7 +16,7 @@
# under the License.
import logging
from flask import g, request, Response
from flask import request, Response
from flask_appbuilder.api import BaseApi, expose, protect, safe
from marshmallow import ValidationError
@@ -102,7 +102,6 @@ class ExploreFormDataRestApi(BaseApi):
item = self.add_model_schema.load(request.json)
tab_id = request.args.get("tab_id")
args = CommandParameters(
actor=g.user,
datasource_id=item["datasource_id"],
datasource_type=item["datasource_type"],
chart_id=item.get("chart_id"),
@@ -173,7 +172,6 @@ class ExploreFormDataRestApi(BaseApi):
item = self.edit_model_schema.load(request.json)
tab_id = request.args.get("tab_id")
args = CommandParameters(
actor=g.user,
datasource_id=item["datasource_id"],
datasource_type=item["datasource_type"],
chart_id=item.get("chart_id"),
@@ -233,7 +231,7 @@ class ExploreFormDataRestApi(BaseApi):
$ref: '#/components/responses/500'
"""
try:
args = CommandParameters(actor=g.user, key=key)
args = CommandParameters(key=key)
form_data = GetFormDataCommand(args).run()
if not form_data:
return self.response_404()
@@ -285,7 +283,7 @@ class ExploreFormDataRestApi(BaseApi):
$ref: '#/components/responses/500'
"""
try:
args = CommandParameters(actor=g.user, key=key)
args = CommandParameters(key=key)
result = DeleteFormDataCommand(args).run()
if not result:
return self.response_404()