QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-05-12 19:35:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(Jinja): Emit time grain to table charts even if they don't have a temporal column (#32871)

Browse Source 
(cherry picked from commit ab22bb1878)
This commit is contained in:
Vitor Avila
2025-03-28 13:48:49 -03:00
committed by Michael S. Molina
parent 56f6e1196c
commit f27bf9ea64
4 changed files with 80 additions and 104 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
superset-frontend/plugins/plugin-chart-table/src/buildQuery.ts
View File

@@ -198,11 +198,6 @@ const buildQuery: BuildQuery<TableChartFormData> = (
(ownState.currentPage ?? 0) * (ownState.pageSize ?? 0);
}
if (!temporalColumn) {
// This query is not using temporal column, so it doesn't need time grain
extras.time_grain_sqla = undefined;
}
let queryObject = {
...baseQueryObject,
columns,

9
superset-frontend/plugins/plugin-chart-table/test/buildQuery.test.ts
View File

@@ -148,14 +148,5 @@ describe('plugin-chart-table', () => {
expect(queries[1].extras?.time_grain_sqla).toEqual(TimeGranularity.MONTH);
expect(queries[1].extras?.where).toEqual("(status IN ('In Process'))");
});
it('should not include time_grain_sqla in extras if temporal colum is not used and keep the rest', () => {
const { queries } = buildQuery(extraQueryFormData);
// Extras in regular query
expect(queries[0].extras?.time_grain_sqla).toBeUndefined();
expect(queries[0].extras?.where).toEqual("(status IN ('In Process'))");
// Extras in summary query
expect(queries[1].extras?.time_grain_sqla).toBeUndefined();
expect(queries[1].extras?.where).toEqual("(status IN ('In Process'))");
});
});
});