fix: validate_parameters and query (#16241)

* fix: validate_parameters and query

* add onQueryChange

(cherry picked from commit 5d3d6b6eae)
This commit is contained in:
Beto Dealmeida
2021-08-12 18:05:27 -07:00
committed by Steven Uray
parent 728c457d4b
commit f2ab391f99
4 changed files with 62 additions and 53 deletions

View File

@@ -61,6 +61,8 @@ interface FieldPropTypes {
onParametersUploadFileChange: (value: any) => string;
changeMethods: { onParametersChange: (value: any) => string } & {
onChange: (value: any) => string;
} & {
onQueryChange: (value: any) => string;
} & { onParametersUploadFileChange: (value: any) => string } & {
onAddTableCatalog: () => void;
onRemoveTableCatalog: (idx: number) => void;
@@ -415,15 +417,15 @@ const queryField = ({
db,
}: FieldPropTypes) => (
<ValidatedInput
id="query"
name="query"
id="query_input"
name="query_input"
required={required}
value={db?.parameters?.query}
value={db?.query_input || ''}
validationMethods={{ onBlur: getValidation }}
errorMessage={validationErrors?.query}
placeholder="e.g. param1=value1&param2=value2"
label="Additional Parameters"
onChange={changeMethods.onParametersChange}
onChange={changeMethods.onQueryChange}
helpText={t('Add additional custom parameters')}
/>
);
@@ -475,6 +477,7 @@ const DatabaseConnectionForm = ({
dbModel: { parameters },
onParametersChange,
onChange,
onQueryChange,
onParametersUploadFileChange,
onAddTableCatalog,
onRemoveTableCatalog,
@@ -496,6 +499,9 @@ const DatabaseConnectionForm = ({
onChange: (
event: FormEvent<InputProps> | { target: HTMLInputElement },
) => void;
onQueryChange: (
event: FormEvent<InputProps> | { target: HTMLInputElement },
) => void;
onParametersUploadFileChange?: (
event: FormEvent<InputProps> | { target: HTMLInputElement },
) => void;
@@ -523,6 +529,7 @@ const DatabaseConnectionForm = ({
changeMethods: {
onParametersChange,
onChange,
onQueryChange,
onParametersUploadFileChange,
onAddTableCatalog,
onRemoveTableCatalog,