QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-05-28 11:15:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: dataset delete and perm delete (#10578)

Browse Source
This commit is contained in:
Daniel Vaz Gaspar
2020-08-13 10:18:13 +01:00
committed by Ville Brofeldt
parent 92b3f88b1a
commit f3bf6cebb7
2 changed files with 27 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
tests/datasets/api_tests.py
View File

@@ -602,10 +602,17 @@ class TestDatasetApi(SupersetTestCase):
Dataset API: Test delete dataset item
"""
dataset = self.insert_default_dataset()
view_menu = security_manager.find_view_menu(dataset.get_perm())
self.assertIsNotNone(view_menu)
view_menu_id = view_menu.id
self.login(username="admin")
uri = f"api/v1/dataset/{dataset.id}"
rv = self.client.delete(uri)
self.assertEqual(rv.status_code, 200)
non_view_menu = db.session.query(security_manager.viewmenu_model).get(
view_menu_id
)
self.assertIsNone(non_view_menu)
def test_delete_item_dataset_not_owned(self):
"""