fix(chart): chart updates are not retained (#23627)

superset-frontend/src/explore/controlUtils/getFormDataFromDashboardContext.test.ts

@@ -18,135 +18,10 @@
  */
 
 import { JsonObject } from '@superset-ui/core';
+import { getExploreFormData } from 'spec/fixtures/mockExploreFormData';
+import { getDashboardFormData } from 'spec/fixtures/mockDashboardFormData';
 import { getFormDataWithDashboardContext } from './getFormDataWithDashboardContext';
 
-const getExploreFormData = (overrides: JsonObject = {}) => ({
-  adhoc_filters: [
-    {
-      clause: 'WHERE' as const,
-      expressionType: 'SIMPLE' as const,
-      operator: 'IN' as const,
-      subject: 'gender',
-      comparator: ['boys'],
-      filterOptionName: '123',
-    },
-    {
-      clause: 'WHERE' as const,
-      expressionType: 'SQL' as const,
-      operator: null,
-      subject: null,
-      comparator: null,
-      sqlExpression: "name = 'John'",
-      filterOptionName: '456',
-    },
-    {
-      clause: 'WHERE' as const,
-      expressionType: 'SQL' as const,
-      operator: null,
-      subject: null,
-      comparator: null,
-      sqlExpression: "city = 'Warsaw'",
-      filterOptionName: '567',
-    },
-    {
-      clause: 'WHERE' as const,
-      expressionType: 'SIMPLE' as const,
-      operator: 'TEMPORAL_RANGE' as const,
-      subject: 'ds',
-      comparator: 'No filter',
-      filterOptionName: '678',
-    },
-  ],
-  adhoc_filters_b: [
-    {
-      clause: 'WHERE' as const,
-      expressionType: 'SQL' as const,
-      operator: null,
-      subject: null,
-      comparator: null,
-      sqlExpression: "country = 'Poland'",
-      filterOptionName: '789',
-    },
-  ],
-  applied_time_extras: {},
-  color_scheme: 'supersetColors',
-  datasource: '2__table',
-  granularity_sqla: 'ds',
-  groupby: ['gender'],
-  metric: {
-    aggregate: 'SUM',
-    column: {
-      column_name: 'num',
-      type: 'BIGINT',
-    },
-    expressionType: 'SIMPLE',
-    label: 'Births',
-  },
-  slice_id: 46,
-  time_range: '100 years ago : now',
-  viz_type: 'pie',
-  ...overrides,
-});
-
-const getDashboardFormData = (overrides: JsonObject = {}) => ({
-  label_colors: {
-    Girls: '#FF69B4',
-    Boys: '#ADD8E6',
-    girl: '#FF69B4',
-    boy: '#ADD8E6',
-  },
-  shared_label_colors: {
-    boy: '#ADD8E6',
-    girl: '#FF69B4',
-  },
-  color_scheme: 'd3Category20b',
-  extra_filters: [
-    {
-      col: '__time_range',
-      op: '==',
-      val: 'No filter',
-    },
-    {
-      col: '__time_grain',
-      op: '==',
-      val: 'P1D',
-    },
-    {
-      col: '__time_col',
-      op: '==',
-      val: 'ds',
-    },
-  ],
-  extra_form_data: {
-    filters: [
-      {
-        col: 'name',
-        op: 'IN',
-        val: ['Aaron'],
-      },
-      {
-        col: 'num_boys',
-        op: '<=',
-        val: 10000,
-      },
-      {
-        col: {
-          sqlExpression: 'totally viable sql expression',
-          expressionType: 'SQL',
-          label: 'My column',
-        },
-        op: 'IN',
-        val: ['Value1', 'Value2'],
-      },
-    ],
-    granularity_sqla: 'ds',
-    time_range: 'Last month',
-    time_grain_sqla: 'PT1S',
-  },
-  dashboardId: 2,
-  ...overrides,
-});
-
 const getExpectedResultFormData = (overrides: JsonObject = {}) => ({
   adhoc_filters: [
     {