QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-05-09 01:46:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(explore): Restore missing dataset states (#22693)

Browse Source
This commit is contained in:
Cody Leff
2023-01-13 17:42:38 +01:00
committed by GitHub
parent 91850ebc57
commit f5c404fc51
2 changed files with 38 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
superset-frontend/src/explore/components/controls/DatasourceControl/index.jsx
View File

@@ -267,11 +267,12 @@ class DatasourceControl extends React.PureComponent {
showSaveDatasetModal,
} = this.state;
const { datasource, onChange, theme } = this.props;
const isMissingDatasource = datasource?.id == null;
const isMissingDatasource = !datasource?.id;
let isMissingParams = false;
if (isMissingDatasource) {
const datasourceId = getUrlParam(URL_PARAMS.datasourceId);
const sliceId = getUrlParam(URL_PARAMS.sliceId);
if (!datasourceId && !sliceId) {
isMissingParams = true;
}
@@ -288,7 +289,7 @@ class DatasourceControl extends React.PureComponent {
const defaultDatasourceMenu = (
<Menu onClick={this.handleMenuItemClick}>
{this.props.isEditable && (
{this.props.isEditable && !isMissingDatasource && (
<Menu.Item
key={EDIT_DATASET}
data-test="edit-dataset"
@@ -308,7 +309,7 @@ class DatasourceControl extends React.PureComponent {
</Menu.Item>
)}
<Menu.Item key={CHANGE_DATASET}>{t('Swap dataset')}</Menu.Item>
{datasource && canAccessSqlLab && (
{!isMissingDatasource && canAccessSqlLab && (
<Menu.Item key={VIEW_IN_SQL_LAB}>{t('View in SQL Lab')}</Menu.Item>
)}
</Menu>
@@ -358,7 +359,10 @@ class DatasourceControl extends React.PureComponent {
}
}
const titleText = getDatasourceTitle(datasource);
const titleText = isMissingDatasource
? t('Missing dataset')
: getDatasourceTitle(datasource);
const tooltip = titleText;
return (