From f659d66fee6fed7e18c3b2d40bd7894c8f8a216b Mon Sep 17 00:00:00 2001 From: "Michael S. Molina" <70410625+michael-s-molina@users.noreply.github.com> Date: Fri, 22 Jan 2021 15:11:38 -0300 Subject: [PATCH] Apply capitalization guidelines - iteration 4 (#12343) (#12450) --- .../nativeFilters/NativeFiltersModal_spec.tsx | 4 +- .../components/SliceHeaderControls.jsx | 4 +- .../nativeFilters/CascadePopover.tsx | 2 +- .../components/nativeFilters/FilterBar.tsx | 2 +- .../nativeFilters/FilterConfigForm.tsx | 6 +-- .../nativeFilters/FilterConfigModal.tsx | 8 ++-- .../components/nativeFilters/FiltersList.tsx | 2 +- .../components/nativeFilters/state.ts | 2 +- .../src/dashboard/util/newComponentFactory.js | 2 +- .../src/datasource/ChangeDatasourceModal.tsx | 2 +- .../src/datasource/DatasourceEditor.jsx | 42 +++++++++---------- 11 files changed, 38 insertions(+), 38 deletions(-) diff --git a/superset-frontend/spec/javascripts/dashboard/components/nativeFilters/NativeFiltersModal_spec.tsx b/superset-frontend/spec/javascripts/dashboard/components/nativeFilters/NativeFiltersModal_spec.tsx index d3f552f4865..a3329c3fcd2 100644 --- a/superset-frontend/spec/javascripts/dashboard/components/nativeFilters/NativeFiltersModal_spec.tsx +++ b/superset-frontend/spec/javascripts/dashboard/components/nativeFilters/NativeFiltersModal_spec.tsx @@ -109,7 +109,7 @@ describe('FiltersConfigModal', () => { await clickCancel(); expect(onCancel.mock.calls).toHaveLength(0); expect(wrapper.find(Alert).text()).toContain( - 'Are you sure you want to cancel? "New Filter" will not be saved.', + 'Are you sure you want to cancel? "New filter" will not be saved.', ); }); @@ -119,7 +119,7 @@ describe('FiltersConfigModal', () => { await clickCancel(); expect(onCancel.mock.calls).toHaveLength(0); expect(wrapper.find(Alert).text()).toContain( - 'Are you sure you want to cancel? "New Filter" and "New Filter" will not be saved.', + 'Are you sure you want to cancel? "New filter" and "New filter" will not be saved.', ); }); }); diff --git a/superset-frontend/src/dashboard/components/SliceHeaderControls.jsx b/superset-frontend/src/dashboard/components/SliceHeaderControls.jsx index f985fe83c8c..dcd142c0f93 100644 --- a/superset-frontend/src/dashboard/components/SliceHeaderControls.jsx +++ b/superset-frontend/src/dashboard/components/SliceHeaderControls.jsx @@ -199,7 +199,7 @@ class SliceHeaderControls extends React.PureComponent { : item} )); - const resizeLabel = isFullSize ? t('Minimize Chart') : t('Maximize Chart'); + const resizeLabel = isFullSize ? t('Minimize chart') : t('Maximize chart'); const menu = ( - {t('View Chart in Explore')} + {t('View chart in Explore')} )} diff --git a/superset-frontend/src/dashboard/components/nativeFilters/CascadePopover.tsx b/superset-frontend/src/dashboard/components/nativeFilters/CascadePopover.tsx index c7519b465b0..2b923704c42 100644 --- a/superset-frontend/src/dashboard/components/nativeFilters/CascadePopover.tsx +++ b/superset-frontend/src/dashboard/components/nativeFilters/CascadePopover.tsx @@ -118,7 +118,7 @@ const CascadePopover: React.FC = ({ - {t('Select Parent Filters')} ({totalChildren}) + {t('Select parent filters')} ({totalChildren}) onVisibleChange(false)} /> diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar.tsx index bc66d532901..abd189a8b61 100644 --- a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar.tsx +++ b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar.tsx @@ -452,7 +452,7 @@ const FilterBar: React.FC = ({ buttonSize="sm" onClick={handleResetAll} > - {t('Reset All')} + {t('Reset all')} @@ -150,7 +150,7 @@ export const FilterConfigForm: React.FC = ({ {t('Filter Name')}} + label={{t('Filter name')}} initialValue={filterToEdit?.name} rules={[{ required: !removed, message: t('Name is required') }]} data-test="name-input" @@ -200,7 +200,7 @@ export const FilterConfigForm: React.FC = ({ {t('Parent Filter')}} + label={{t('Parent filter')}} initialValue={parentFilterOptions.find( ({ value }) => value === filterToEdit?.cascadeParentIds[0], )} diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FilterConfigModal.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FilterConfigModal.tsx index 2be67dba835..c2aad918a80 100644 --- a/superset-frontend/src/dashboard/components/nativeFilters/FilterConfigModal.tsx +++ b/superset-frontend/src/dashboard/components/nativeFilters/FilterConfigModal.tsx @@ -286,7 +286,7 @@ export function FilterConfigModal({ function getFilterTitle(id: string) { return ( - formValues.filters[id]?.name ?? filterConfigMap[id]?.name ?? 'New Filter' + formValues.filters[id]?.name ?? filterConfigMap[id]?.name ?? 'New filter' ); } @@ -353,7 +353,7 @@ export function FilterConfigModal({ return formValues; } catch (error) { - console.warn('Filter Configuration Failed:', error); + console.warn('Filter configuration failed:', error); if (!error.errorFields || !error.errorFields.length) return null; // not a validation error @@ -484,7 +484,7 @@ export function FilterConfigModal({ return ( - {t('Add Filter')} + {t('Add filter')} } > diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FiltersList.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FiltersList.tsx index 5c91bf61f4e..f85e31b0ae2 100644 --- a/superset-frontend/src/dashboard/components/nativeFilters/FiltersList.tsx +++ b/superset-frontend/src/dashboard/components/nativeFilters/FiltersList.tsx @@ -53,7 +53,7 @@ const FiltersList = ({ setEditFilter, setDataset }: FiltersListProps) => { diff --git a/superset-frontend/src/dashboard/components/nativeFilters/state.ts b/superset-frontend/src/dashboard/components/nativeFilters/state.ts index 37b7198ceef..6a5388e2505 100644 --- a/superset-frontend/src/dashboard/components/nativeFilters/state.ts +++ b/superset-frontend/src/dashboard/components/nativeFilters/state.ts @@ -88,7 +88,7 @@ export function useFilterScopeTree(): { children: [], key: DASHBOARD_ROOT_ID, type: DASHBOARD_ROOT_TYPE, - title: t('All Panels'), + title: t('All panels'), }; buildTree(layout[DASHBOARD_ROOT_ID], tree, layout, charts); return { treeData: [tree], layout }; diff --git a/superset-frontend/src/dashboard/util/newComponentFactory.js b/superset-frontend/src/dashboard/util/newComponentFactory.js index 1c3d2cf16a6..d3f3a828f59 100644 --- a/superset-frontend/src/dashboard/util/newComponentFactory.js +++ b/superset-frontend/src/dashboard/util/newComponentFactory.js @@ -50,7 +50,7 @@ const typeToDefaultMetaData = { [MARKDOWN_TYPE]: { width: GRID_DEFAULT_CHART_WIDTH, height: 50 }, [ROW_TYPE]: { background: BACKGROUND_TRANSPARENT }, [TABS_TYPE]: null, - [TAB_TYPE]: { text: 'New Tab' }, + [TAB_TYPE]: { text: 'New tab' }, }; function uuid(type) { diff --git a/superset-frontend/src/datasource/ChangeDatasourceModal.tsx b/superset-frontend/src/datasource/ChangeDatasourceModal.tsx index c2b43eb67f7..5c144e4d786 100644 --- a/superset-frontend/src/datasource/ChangeDatasourceModal.tsx +++ b/superset-frontend/src/datasource/ChangeDatasourceModal.tsx @@ -220,7 +220,7 @@ const ChangeDatasourceModal: FunctionComponent = ({ show={show} onHide={onHide} responsive - title={t('Change Dataset')} + title={t('Change dataset')} width={confirmChange ? '432px' : ''} height={confirmChange ? 'auto' : '480px'} hideFooter={!confirmChange} diff --git a/superset-frontend/src/datasource/DatasourceEditor.jsx b/superset-frontend/src/datasource/DatasourceEditor.jsx index 4427b22b072..ca19a5c05fb 100644 --- a/superset-frontend/src/datasource/DatasourceEditor.jsx +++ b/superset-frontend/src/datasource/DatasourceEditor.jsx @@ -132,7 +132,7 @@ function ColumnCollectionTable({ {showExpression && ( } @@ -172,13 +172,13 @@ function ColumnCollectionTable({ )} {t('The pattern of timestamp format. For strings use ')} - {t('python datetime string pattern')} + {t('Python datetime string pattern')} {t(' expression which needs to adhere to the ')} @@ -207,10 +207,10 @@ function ColumnCollectionTable({ } columnLabels={{ column_name: t('Column'), - type: t('Data Type'), - groupby: t('Is Dimension'), - is_dttm: t('Is Temporal'), - filterable: t('Is Filterable'), + type: t('Data type'), + groupby: t('Is dimension'), + is_dttm: t('Is temporal'), + filterable: t('Is filterable'), }} onChange={onChange} itemRenderers={{ @@ -537,7 +537,7 @@ class DatasourceEditor extends React.PureComponent { {this.state.isSqla && ( { this.onDatasourcePropChange('table_name', table); }} - placeholder={t('dataset name')} + placeholder={t('Dataset name')} disabled={!this.state.isEditMode} /> } @@ -835,7 +835,7 @@ class DatasourceEditor extends React.PureComponent { columnLabels={{ metric_name: t('Metric'), verbose_name: t('Label'), - expression: t('SQL Expression'), + expression: t('SQL expression'), }} expandFieldset={ @@ -857,13 +857,13 @@ class DatasourceEditor extends React.PureComponent { /> } /> } /> } /> } /> @@ -1024,7 +1024,7 @@ class DatasourceEditor extends React.PureComponent { tab={ } key={3}