diff --git a/superset-frontend/plugins/legacy-preset-chart-deckgl/src/layers/Screengrid/Screengrid.tsx b/superset-frontend/plugins/legacy-preset-chart-deckgl/src/layers/Screengrid/Screengrid.tsx index d0153688b56..14d3f20688f 100644 --- a/superset-frontend/plugins/legacy-preset-chart-deckgl/src/layers/Screengrid/Screengrid.tsx +++ b/superset-frontend/plugins/legacy-preset-chart-deckgl/src/layers/Screengrid/Screengrid.tsx @@ -23,7 +23,6 @@ import { memo, useCallback, useEffect, useRef, useState } from 'react'; import { ScreenGridLayer } from '@deck.gl/aggregation-layers'; import { JsonObject, JsonValue, QueryFormData, t } from '@superset-ui/core'; -import { noop } from 'lodash'; import sandboxedEval from '../../utils/sandbox'; import { commonLayerProps } from '../common'; import TooltipRow from '../../TooltipRow'; @@ -135,7 +134,7 @@ const DeckGLScreenGrid = (props: DeckGLScreenGridProps) => { }, []); const getLayers = useCallback(() => { - const layer = getLayer(props.formData, props.payload, noop, setTooltip); + const layer = getLayer(props.formData, props.payload, () => {}, setTooltip); return [layer]; }, [props.formData, props.payload, setTooltip]); diff --git a/superset-frontend/plugins/plugin-chart-echarts/src/utils/eventHandlers.ts b/superset-frontend/plugins/plugin-chart-echarts/src/utils/eventHandlers.ts index 9afa2fcdef3..cd76f27c4d0 100644 --- a/superset-frontend/plugins/plugin-chart-echarts/src/utils/eventHandlers.ts +++ b/superset-frontend/plugins/plugin-chart-echarts/src/utils/eventHandlers.ts @@ -26,7 +26,6 @@ import { getNumberFormatter, getTimeFormatter, } from '@superset-ui/core'; -import { noop } from 'lodash'; import { BaseTransformedProps, @@ -166,7 +165,7 @@ export const allEventHandlers = ( setDataMask, emitCrossFilters, ) - : noop, + : () => {}, contextmenu: contextMenuEventHandler( groupby, onContextMenu, diff --git a/superset-frontend/src/features/home/ChartTable.tsx b/superset-frontend/src/features/home/ChartTable.tsx index 30d1d41afaa..e8026f00358 100644 --- a/superset-frontend/src/features/home/ChartTable.tsx +++ b/superset-frontend/src/features/home/ChartTable.tsx @@ -18,7 +18,6 @@ */ import { useEffect, useMemo, useState } from 'react'; import { t } from '@superset-ui/core'; -import { filter } from 'lodash'; import { useChartEditModal, useFavoriteStatus, @@ -76,7 +75,7 @@ function ChartTable({ TableTab.Other, ); - const filteredOtherTabData = filter(otherTabData, obj => 'viz_type' in obj); + const filteredOtherTabData = otherTabData?.filter(obj => 'viz_type' in obj); const { state: { loading, resourceCollection: charts, bulkSelectEnabled }, diff --git a/superset-frontend/src/features/home/DashboardTable.tsx b/superset-frontend/src/features/home/DashboardTable.tsx index 01b385138d2..28cf137026d 100644 --- a/superset-frontend/src/features/home/DashboardTable.tsx +++ b/superset-frontend/src/features/home/DashboardTable.tsx @@ -18,7 +18,6 @@ */ import { useEffect, useMemo, useState } from 'react'; import { SupersetClient, t } from '@superset-ui/core'; -import { filter } from 'lodash'; import { useFavoriteStatus, useListViewResource } from 'src/views/CRUD/hooks'; import { Dashboard, DashboardTableProps, TableTab } from 'src/views/CRUD/types'; import handleResourceExport from 'src/utils/export'; @@ -61,10 +60,7 @@ function DashboardTable({ TableTab.Other, ); - const filteredOtherTabData = filter( - otherTabData, - obj => !('viz_type' in obj), - ); + const filteredOtherTabData = otherTabData.filter(obj => !('viz_type' in obj)); const { state: { loading, resourceCollection: dashboards },