QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 08:04:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: bump react-redux to 5.1.2, whittling console noise (#10602)

Browse Source 
* chore: bump react-redux to 5.1.2

* fixing spy, and thus the breaking test.

* relabeling tests to UNSAFE_componentWillReceiveProps because why not.
This commit is contained in:
Evan Rusackas
2020-08-16 21:29:08 -07:00
committed by GitHub
parent ed9b6dbf2b
commit f868580f64
8 changed files with 150 additions and 147 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
superset-frontend/spec/javascripts/explore/components/ExploreViewContainer_spec.jsx
View File

@@ -79,7 +79,7 @@ describe('ExploreViewContainer', () => {
expect(wrapper.find(ChartContainer)).toExist();
});
describe('componentWillReceiveProps()', () => {
describe('UNSAFE_componentWillReceiveProps()', () => {
it('when controls change, should call resetControls', () => {
expect(wrapper.instance().props.controls.viz_type.value).toBe('table');
const resetControls = sinon.stub(
@@ -91,7 +91,7 @@ describe('ExploreViewContainer', () => {
'triggerQuery',
);
// triggers componentWillReceiveProps
// triggers UNSAFE_componentWillReceiveProps
wrapper.setProps({
controls: {
viz_type: {

2
superset-frontend/spec/javascripts/explore/components/SelectControl_spec.jsx
View File

@@ -145,7 +145,7 @@ describe('SelectControl', () => {
});
});
describe('componentWillReceiveProps', () => {
describe('UNSAFE_componentWillReceiveProps', () => {
it('sets state.options if props.choices has changed', () => {
const updatedOptions = [
{ value: 'three', label: 'three' },