mirror of
https://github.com/apache/superset.git
synced 2026-04-24 18:44:53 +00:00
chore: replace Lodash usage with native JS implementation (#31907)
Signed-off-by: hainenber <dotronghai96@gmail.com>
This commit is contained in:
@@ -50,7 +50,7 @@ import { mountExploreUrl } from 'src/explore/exploreUtils';
|
||||
import { postFormData } from 'src/explore/exploreUtils/formData';
|
||||
import { URL_PARAMS } from 'src/constants';
|
||||
import { SelectValue } from 'antd/lib/select';
|
||||
import { isEmpty, isString } from 'lodash';
|
||||
import { isEmpty } from 'lodash';
|
||||
|
||||
interface QueryDatabase {
|
||||
id?: number;
|
||||
@@ -280,7 +280,7 @@ export const SaveDatasetModal = ({
|
||||
// Remove the special filters entry from the templateParams
|
||||
// before saving the dataset.
|
||||
let templateParams;
|
||||
if (isString(datasource?.templateParams)) {
|
||||
if (typeof datasource?.templateParams === 'string') {
|
||||
const p = JSON.parse(datasource.templateParams);
|
||||
/* eslint-disable-next-line no-underscore-dangle */
|
||||
if (p._filters) {
|
||||
|
||||
@@ -50,7 +50,7 @@ import type {
|
||||
CursorPosition,
|
||||
} from 'src/SqlLab/types';
|
||||
import type { DatabaseObject } from 'src/features/databases/types';
|
||||
import { debounce, throttle, isBoolean, isEmpty } from 'lodash';
|
||||
import { debounce, throttle, isEmpty } from 'lodash';
|
||||
import Modal from 'src/components/Modal';
|
||||
import Mousetrap from 'mousetrap';
|
||||
import Button from 'src/components/Button';
|
||||
@@ -281,9 +281,10 @@ const SqlEditor: FC<Props> = ({
|
||||
if (unsavedQueryEditor?.id === queryEditor.id) {
|
||||
dbId = unsavedQueryEditor.dbId || dbId;
|
||||
latestQueryId = unsavedQueryEditor.latestQueryId || latestQueryId;
|
||||
hideLeftBar = isBoolean(unsavedQueryEditor.hideLeftBar)
|
||||
? unsavedQueryEditor.hideLeftBar
|
||||
: hideLeftBar;
|
||||
hideLeftBar =
|
||||
typeof unsavedQueryEditor.hideLeftBar === 'boolean'
|
||||
? unsavedQueryEditor.hideLeftBar
|
||||
: hideLeftBar;
|
||||
}
|
||||
return {
|
||||
hasSqlStatement: Boolean(queryEditor.sql?.trim().length > 0),
|
||||
|
||||
Reference in New Issue
Block a user