From f9ff3259b3754a9de21358aea8bc6cce78aa810a Mon Sep 17 00:00:00 2001 From: "Michael S. Molina" <70410625+michael-s-molina@users.noreply.github.com> Date: Tue, 27 May 2025 17:02:10 -0300 Subject: [PATCH] fix: Makes time compare migration more resilient (#33592) (cherry picked from commit b7ba50033a8d57918ab9e55bb56c9ad713044041) --- superset/migrations/shared/migrate_viz/processors.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/superset/migrations/shared/migrate_viz/processors.py b/superset/migrations/shared/migrate_viz/processors.py index 9a7b03382bd..c60b6bd42fc 100644 --- a/superset/migrations/shared/migrate_viz/processors.py +++ b/superset/migrations/shared/migrate_viz/processors.py @@ -294,9 +294,11 @@ class TimeseriesChart(MigrateViz): if (rolling_type := self.data.get("rolling_type")) and rolling_type != "None": self.data["rolling_type"] = rolling_type - if time_compare := self.data.get("time_compare"): + if (time_compare := self.data.get("time_compare")) is not None: self.data["time_compare"] = [ - value + " ago" for value in as_list(time_compare) if value + v if v.endswith(" ago") else v + " ago" + for value in as_list(time_compare) + if (v := value.strip()) ] comparison_type = self.data.get("comparison_type") or "values"