QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-20 16:44:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: dataset editor improvements (#10444)

Browse Source
This commit is contained in:
Lily Kuang
2020-08-04 11:52:35 -07:00
committed by GitHub
parent 9c5b0e1c86
commit fa07506d0d
8 changed files with 309 additions and 343 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
superset-frontend/spec/javascripts/profile/EditableTitle_spec.tsx
View File

@@ -34,7 +34,7 @@ describe('EditableTitle', () => {
value: 'new title',
},
};
const editableWrapper = shallow(<EditableTable {...mockProps} />);
let editableWrapper = shallow(<EditableTable {...mockProps} />);
const notEditableWrapper = shallow(
<EditableTable title="my title" onSaveTitle={callback} />,
);
@@ -60,8 +60,7 @@ describe('EditableTitle', () => {
describe('should handle change', () => {
afterEach(() => {
editableWrapper.setState({ title: 'my title' });
editableWrapper.setState({ lastTitle: 'my title' });
editableWrapper = shallow(<EditableTable {...mockProps} />);
});
it('should change title', () => {
editableWrapper.find('input').simulate('change', mockEvent);
@@ -79,8 +78,7 @@ describe('EditableTitle', () => {
});
afterEach(() => {
callback.resetHistory();
editableWrapper.setState({ title: 'my title' });
editableWrapper.setState({ lastTitle: 'my title' });
editableWrapper = shallow(<EditableTable {...mockProps} />);
});
it('default input type should be text', () => {
@@ -88,7 +86,7 @@ describe('EditableTitle', () => {
});
it('should trigger callback', () => {
editableWrapper.setState({ title: 'new title' });
editableWrapper.find('input').simulate('change', mockEvent);
editableWrapper.find('input').simulate('blur');
expect(editableWrapper.find('input').props().type).toBe('button');
expect(callback.callCount).toBe(1);
@@ -101,7 +99,6 @@ describe('EditableTitle', () => {
expect(callback.callCount).toBe(0);
});
it('should not save empty title', () => {
editableWrapper.setState({ title: '' });
editableWrapper.find('input').simulate('blur');
expect(editableWrapper.find('input').props().type).toBe('button');
expect(editableWrapper.find('input').props().value).toBe('my title');