QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 16:14:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: dataset editor improvements (#10444)

Browse Source
This commit is contained in:
Lily Kuang
2020-08-04 11:52:35 -07:00
committed by GitHub
parent 9c5b0e1c86
commit fa07506d0d
8 changed files with 309 additions and 343 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
superset-frontend/src/datasource/DatasourceEditor.jsx
View File

@@ -98,18 +98,23 @@ function ColumnCollectionTable({
<Field
fieldKey="expression"
label={t('SQL Expression')}
control={<TextControl />}
control={
<TextAreaControl
language="markdown"
offerEditInModal={false}
/>
}
/>
)}
<Field
fieldKey="verbose_name"
label={t('Label')}
control={<TextControl />}
control={<TextControl placeholder={t('Label')} />}
/>
<Field
fieldKey="description"
label={t('Description')}
control={<TextControl />}
control={<TextControl placeholder={t('Description')} />}
/>
{allowEditDataType && (
<Field
@@ -145,7 +150,7 @@ function ColumnCollectionTable({
database/column name level via the extra parameter.`)}
</div>
}
control={<TextControl />}
control={<TextControl placeholder={'%y/%m/%d'} />}
/>
</Fieldset>
</FormContainer>
@@ -603,12 +608,12 @@ export class DatasourceEditor extends React.PureComponent {
<Field
fieldKey="description"
label={t('Description')}
control={<TextControl />}
control={<TextControl placeholder={t('Description')} />}
/>
<Field
fieldKey="d3format"
label={t('D3 Format')}
control={<TextControl />}
control={<TextControl placeholder="%y/%m/%d" />}
/>
<Field
label={t('Warning Message')}
@@ -616,7 +621,7 @@ export class DatasourceEditor extends React.PureComponent {
description={t(
'Warning message to display in the metric selector',
)}
control={<TextControl />}
control={<TextControl placeholder={t('Warning Message')} />}
/>
</Fieldset>
</FormContainer>