QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 08:04:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

Disable user access request (#4405)

Browse Source 
* add feature flag to config

* wrap check around a feature flag

* add flag to the model view

* remove access request from seurity tests
This commit is contained in:
timifasubaa
2018-02-14 14:49:22 -08:00
committed by Maxime Beauchemin
parent 22d555b14e
commit fa0aa33767
5 changed files with 228 additions and 220 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
tests/security_tests.py
View File

@@ -1,4 +1,4 @@
from superset import security, sm
from superset import app, security, sm
from .base_tests import SupersetTestCase
@@ -76,7 +76,9 @@ class RolePermissionTests(SupersetTestCase):
self.assertIn(('muldelete', 'DruidDatasourceModelView'), perm_set)
def assert_cannot_alpha(self, perm_set):
self.assert_cannot_write('AccessRequestsModelView', perm_set)
if app.config.get('ENABLE_ACCESS_REQUEST'):
self.assert_cannot_write('AccessRequestsModelView', perm_set)
self.assert_can_all('AccessRequestsModelView', perm_set)
self.assert_cannot_write('Queries', perm_set)
self.assert_cannot_write('RoleModelView', perm_set)
self.assert_cannot_write('UserDBModelView', perm_set)
@@ -85,7 +87,6 @@ class RolePermissionTests(SupersetTestCase):
self.assert_can_all('DatabaseAsync', perm_set)
self.assert_can_all('DatabaseView', perm_set)
self.assert_can_all('DruidClusterModelView', perm_set)
self.assert_can_all('AccessRequestsModelView', perm_set)
self.assert_can_all('RoleModelView', perm_set)
self.assert_can_all('UserDBModelView', perm_set)
@@ -104,9 +105,10 @@ class RolePermissionTests(SupersetTestCase):
self.assertTrue(security.is_admin_only(
sm.find_permission_view_menu('can_delete', 'DatabaseView')))
self.assertTrue(security.is_admin_only(
sm.find_permission_view_menu(
'can_show', 'AccessRequestsModelView')))
if app.config.get('ENABLE_ACCESS_REQUEST'):
self.assertTrue(security.is_admin_only(
sm.find_permission_view_menu(
'can_show', 'AccessRequestsModelView')))
self.assertTrue(security.is_admin_only(
sm.find_permission_view_menu(
'can_edit', 'UserDBModelView')))