QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-17 15:15:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: rm grace period field for reports modal (#12800)

Browse Source 
* add rc4 changelog entries

(cherry picked from commit 5719fefdd4)

* only show grace period for alerts + fix dropdown styling

* fix lint

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
This commit is contained in:
Moriah Kreeger
2021-01-28 15:17:14 -08:00
committed by GitHub
parent ef724069f3
commit fa8c492acd
3 changed files with 703 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
superset-frontend/spec/javascripts/views/CRUD/alert/AlertReportModal_spec.jsx
View File

@@ -212,7 +212,15 @@ describe('AlertReportModal', () => {
expect(wrapper.find('input[name="working_timeout"]')).toExist();
});
it('renders input element for grace period', () => {
expect(wrapper.find('input[name="grace_period"]')).toExist();
it('renders input element for grace period for alert only', async () => {
const props = {
...mockedProps,
isReport: false,
};
const addWrapper = await mountAndWait(props);
expect(addWrapper.find('input[name="grace_period"]')).toExist();
expect(wrapper.find('input[name="grace_period"]')).toHaveLength(0);
});
});