QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-23 18:14:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Drill by with GLOBAL_ASYNC_QUERIES (#27066)

Browse Source
This commit is contained in:
Kamil Gabryjelski
2024-02-09 21:49:33 +01:00
committed by GitHub
parent c010f99020
commit faaf14bcc4
3 changed files with 77 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

52
superset-frontend/src/components/Chart/chartAction.js
View File

@@ -370,6 +370,29 @@ export function addChart(chart, key) {
return { type: ADD_CHART, chart, key };
}
export function handleChartDataResponse(response, json, useLegacyApi) {
if (isFeatureEnabled(FeatureFlag.GlobalAsyncQueries)) {
// deal with getChartDataRequest transforming the response data
const result = 'result' in json ? json.result : json;
switch (response.status) {
case 200:
// Query results returned synchronously, meaning query was already cached.
return Promise.resolve(result);
case 202:
// Query is running asynchronously and we must await the results
if (useLegacyApi) {
return waitForAsyncData(result[0]);
}
return waitForAsyncData(result);
default:
throw new Error(
`Received unexpected response status (${response.status}) while fetching chart data`,
);
}
}
return json.result;
}
export function exploreJSON(
formData,
force = false,
@@ -404,31 +427,11 @@ export function exploreJSON(
dispatch(chartUpdateStarted(controller, formData, key));
const [useLegacyApi] = getQuerySettings(formData);
const chartDataRequestCaught = chartDataRequest
.then(({ response, json }) => {
if (isFeatureEnabled(FeatureFlag.GlobalAsyncQueries)) {
// deal with getChartDataRequest transforming the response data
const result = 'result' in json ? json.result : json;
const [useLegacyApi] = getQuerySettings(formData);
switch (response.status) {
case 200:
// Query results returned synchronously, meaning query was already cached.
return Promise.resolve(result);
case 202:
// Query is running asynchronously and we must await the results
if (useLegacyApi) {
return waitForAsyncData(result[0]);
}
return waitForAsyncData(result);
default:
throw new Error(
`Received unexpected response status (${response.status}) while fetching chart data`,
);
}
}
return json.result;
})
.then(({ response, json }) =>
handleChartDataResponse(response, json, useLegacyApi),
)
.then(queriesResponse => {
queriesResponse.forEach(resultItem =>
dispatch(
@@ -487,7 +490,6 @@ export function exploreJSON(
});
// only retrieve annotations when calling the legacy API
const [useLegacyApi] = getQuerySettings(formData);
const annotationLayers = useLegacyApi
? formData.annotation_layers || []
: [];