QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-06-05 15:49:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Drill by with GLOBAL_ASYNC_QUERIES (#27066)

Browse Source
This commit is contained in:
Kamil Gabryjelski
2024-02-09 21:49:33 +01:00
committed by GitHub
parent c010f99020
commit faaf14bcc4
3 changed files with 77 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

43
superset-frontend/src/components/Chart/chartActions.test.js
View File

@@ -21,10 +21,12 @@ import fetchMock from 'fetch-mock';
import sinon from 'sinon';
import * as chartlib from '@superset-ui/core';
import { SupersetClient } from '@superset-ui/core';
import { FeatureFlag, SupersetClient } from '@superset-ui/core';
import { LOG_EVENT } from 'src/logger/actions';
import * as exploreUtils from 'src/explore/exploreUtils';
import * as actions from 'src/components/Chart/chartAction';
import * as asyncEvent from 'src/middleware/asyncEvent';
import { handleChartDataResponse } from 'src/components/Chart/chartAction';
describe('chart actions', () => {
const MOCK_URL = '/mockURL';
@@ -33,6 +35,7 @@ describe('chart actions', () => {
let getChartDataUriStub;
let metadataRegistryStub;
let buildQueryRegistryStub;
let waitForAsyncDataStub;
let fakeMetadata;
const setupDefaultFetchMock = () => {
@@ -66,6 +69,9 @@ describe('chart actions', () => {
result_format: 'json',
}),
}));
waitForAsyncDataStub = sinon
.stub(asyncEvent, 'waitForAsyncData')
.callsFake(data => Promise.resolve(data));
});
afterEach(() => {
@@ -74,6 +80,11 @@ describe('chart actions', () => {
fetchMock.resetHistory();
metadataRegistryStub.restore();
buildQueryRegistryStub.restore();
waitForAsyncDataStub.restore();
global.featureFlags = {
[FeatureFlag.GlobalAsyncQueries]: false,
};
});
describe('v1 API', () => {
@@ -114,6 +125,36 @@ describe('chart actions', () => {
expect(fetchMock.calls(mockBigIntUrl)).toHaveLength(1);
expect(json.value.toString()).toEqual(expectedBigNumber);
});
it('handleChartDataResponse should return result if GlobalAsyncQueries flag is disabled', async () => {
const result = await handleChartDataResponse(
{ status: 200 },
{ result: [1, 2, 3] },
);
expect(result).toEqual([1, 2, 3]);
});
it('handleChartDataResponse should handle responses when GlobalAsyncQueries flag is enabled and results are returned synchronously', async () => {
global.featureFlags = {
[FeatureFlag.GlobalAsyncQueries]: true,
};
const result = await handleChartDataResponse(
{ status: 200 },
{ result: [1, 2, 3] },
);
expect(result).toEqual([1, 2, 3]);
});
it('handleChartDataResponse should handle responses when GlobalAsyncQueries flag is enabled and query is running asynchronously', async () => {
global.featureFlags = {
[FeatureFlag.GlobalAsyncQueries]: true,
};
const result = await handleChartDataResponse(
{ status: 202 },
{ result: [1, 2, 3] },
);
expect(result).toEqual([1, 2, 3]);
});
});
describe('legacy API', () => {