QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-22 09:35:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(sqllab): wiped out unsaved changes by delayed actions (#21877)

Browse Source
This commit is contained in:
JUST.in DO IT
2022-10-27 13:20:34 -07:00
committed by GitHub
parent 06da7bf65c
commit fb8231b50c
2 changed files with 54 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
superset-frontend/src/SqlLab/reducers/sqlLab.test.js
View File

@@ -191,13 +191,33 @@ describe('sqlLabReducer', () => {
const selectedText = 'TEST';
const action = {
type: actions.QUERY_EDITOR_SET_SELECTED_TEXT,
queryEditor: newState.queryEditors[0],
queryEditor: qe,
sql: selectedText,
};
expect(newState.queryEditors[0].selectedText).toBeFalsy();
expect(qe.selectedText).toBeFalsy();
newState = sqlLabReducer(newState, action);
expect(newState.unsavedQueryEditor.selectedText).toBe(selectedText);
expect(newState.unsavedQueryEditor.id).toBe(newState.queryEditors[0].id);
expect(newState.unsavedQueryEditor.id).toBe(qe.id);
});
it('should not wiped out unsaved changes while delayed async call intercepted', () => {
const expectedSql = 'Updated SQL WORKING IN PROGRESS--';
const action = {
type: actions.QUERY_EDITOR_SET_SQL,
queryEditor: qe,
sql: expectedSql,
};
newState = sqlLabReducer(newState, action);
expect(newState.unsavedQueryEditor.sql).toBe(expectedSql);
const interceptedAction = {
type: actions.QUERY_EDITOR_SET_FUNCTION_NAMES,
queryEditor: newState.queryEditors[0],
functionNames: ['func1', 'func2'],
};
newState = sqlLabReducer(newState, interceptedAction);
expect(newState.unsavedQueryEditor.sql).toBe(expectedSql);
expect(newState.queryEditors[0].functionNames).toBe(
interceptedAction.functionNames,
);
});
});
describe('Tables', () => {