QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 16:14:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Do not show stacktraces on some intentionally-thrown errors (#9056)

Browse Source 
* Do not show stacktraces on some intentionally-thrown errors

* Fix pylint error

* Fix JavaScript looking for the wrong key in error response from connection check

* format -> f-string

* Run black because PyCharm missed it on the last save
This commit is contained in:
Will Barrett
2020-02-04 21:01:43 -08:00
committed by GitHub
parent 6cb4ce0e19
commit fc1c9428e3
4 changed files with 31 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
superset/views/base.py
View File

@@ -63,12 +63,9 @@ def get_error_msg():
return error_msg
def json_error_response(msg=None, status=500, stacktrace=None, payload=None, link=None):
def json_error_response(msg=None, status=500, payload=None, link=None):
if not payload:
payload = {"error": "{}".format(msg)}
if not stacktrace:
stacktrace = utils.get_stacktrace()
payload["stacktrace"] = stacktrace
if link:
payload["link"] = link
@@ -124,30 +121,19 @@ def handle_api_exception(f):
except SupersetSecurityException as e:
logging.exception(e)
return json_error_response(
utils.error_msg_from_exception(e),
status=e.status,
stacktrace=utils.get_stacktrace(),
link=e.link,
utils.error_msg_from_exception(e), status=e.status, link=e.link
)
except SupersetException as e:
logging.exception(e)
return json_error_response(
utils.error_msg_from_exception(e),
stacktrace=utils.get_stacktrace(),
status=e.status,
utils.error_msg_from_exception(e), status=e.status
)
except HTTPException as e:
logging.exception(e)
return json_error_response(
utils.error_msg_from_exception(e),
stacktrace=traceback.format_exc(),
status=e.code,
)
return json_error_response(utils.error_msg_from_exception(e), status=e.code)
except Exception as e: # pylint: disable=broad-except
logging.exception(e)
return json_error_response(
utils.error_msg_from_exception(e), stacktrace=utils.get_stacktrace()
)
return json_error_response(utils.error_msg_from_exception(e))
return functools.update_wrapper(wraps, f)