fix(sqllab): duplicate error message (#31353)

This commit is contained in:
Beto Dealmeida
2024-12-09 12:31:00 -05:00
committed by GitHub
parent 3bfead66c4
commit fc45647440
3 changed files with 16 additions and 34 deletions

View File

@@ -30,7 +30,6 @@ import fetchMock from 'fetch-mock';
import ResultSet from 'src/SqlLab/components/ResultSet';
import {
cachedQuery,
failedQueryWithErrorMessage,
failedQueryWithErrors,
queries,
runningQuery,
@@ -41,6 +40,11 @@ import {
failedQueryWithFrontendTimeoutErrors,
} from 'src/SqlLab/fixtures';
jest.mock(
'src/components/ErrorMessage/ErrorMessageWithStackTrace',
() => () => <div data-test="error-message">Error</div>,
);
const mockedProps = {
cache: true,
queryId: queries[0].id,
@@ -93,15 +97,6 @@ const cachedQueryState = {
},
},
};
const failedQueryWithErrorMessageState = {
...initialState,
sqlLab: {
...initialState.sqlLab,
queries: {
[failedQueryWithErrorMessage.id]: failedQueryWithErrorMessage,
},
},
};
const failedQueryWithErrorsState = {
...initialState,
sqlLab: {
@@ -314,26 +309,17 @@ describe('ResultSet', () => {
expect(getByText('fetching')).toBeInTheDocument();
});
test('should render a failed query with an error message', async () => {
await waitFor(() => {
setup(
{ ...mockedProps, queryId: failedQueryWithErrorMessage.id },
mockStore(failedQueryWithErrorMessageState),
);
});
expect(screen.getByText('Database error')).toBeInTheDocument();
expect(screen.getByText('Something went wrong')).toBeInTheDocument();
});
test('should render a failed query with an errors object', async () => {
const { errors } = failedQueryWithErrors;
await waitFor(() => {
setup(
{ ...mockedProps, queryId: failedQueryWithErrors.id },
mockStore(failedQueryWithErrorsState),
);
});
expect(screen.getByText('Database error')).toBeInTheDocument();
const errorMessages = screen.getAllByTestId('error-message');
expect(errorMessages).toHaveLength(errors.length);
});
test('should render a timeout error with a retrial button', async () => {