mirror of
https://github.com/apache/superset.git
synced 2026-04-28 04:25:07 +00:00
chore(frontend): comprehensive TypeScript quality improvements (#37625)
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
@@ -0,0 +1,94 @@
|
||||
/**
|
||||
* Licensed to the Apache Software Foundation (ASF) under one
|
||||
* or more contributor license agreements. See the NOTICE file
|
||||
* distributed with this work for additional information
|
||||
* regarding copyright ownership. The ASF licenses this file
|
||||
* to you under the Apache License, Version 2.0 (the
|
||||
* "License"); you may not use this file except in compliance
|
||||
* with the License. You may obtain a copy of the License at
|
||||
*
|
||||
* http://www.apache.org/licenses/LICENSE-2.0
|
||||
*
|
||||
* Unless required by applicable law or agreed to in writing,
|
||||
* software distributed under the License is distributed on an
|
||||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
||||
* KIND, either express or implied. See the License for the
|
||||
* specific language governing permissions and limitations
|
||||
* under the License.
|
||||
*/
|
||||
import { reactify } from '@superset-ui/core';
|
||||
import { styled } from '@apache-superset/core/ui';
|
||||
import Component from './Partition';
|
||||
|
||||
// Type-erase the render function to allow flexible prop spreading in the wrapper.
|
||||
// The Partition render function has typed props, but the wrapper passes props via spread
|
||||
// which TypeScript cannot verify at compile time. Props are validated at runtime.
|
||||
const ReactComponent = reactify(
|
||||
Component as unknown as (
|
||||
container: HTMLDivElement,
|
||||
props: Record<string, unknown>,
|
||||
) => void,
|
||||
);
|
||||
|
||||
interface PartitionWrapperProps {
|
||||
className?: string;
|
||||
[key: string]: unknown;
|
||||
}
|
||||
|
||||
const Partition = ({ className, ...otherProps }: PartitionWrapperProps) => (
|
||||
<div className={className}>
|
||||
<ReactComponent {...otherProps} />
|
||||
</div>
|
||||
);
|
||||
|
||||
export default styled(Partition)`
|
||||
${({ theme }) => `
|
||||
.superset-legacy-chart-partition {
|
||||
position: relative;
|
||||
}
|
||||
|
||||
.superset-legacy-chart-partition .chart {
|
||||
display: block;
|
||||
margin: auto;
|
||||
font-size: ${theme.fontSizeSM}px;
|
||||
}
|
||||
|
||||
.superset-legacy-chart-partition rect {
|
||||
stroke: ${theme.colorBorderSecondary};
|
||||
fill: ${theme.colorBgLayout};
|
||||
fill-opacity: 80%;
|
||||
transition: fill-opacity 180ms linear;
|
||||
cursor: pointer;
|
||||
}
|
||||
|
||||
.superset-legacy-chart-partition rect:hover {
|
||||
fill-opacity: 1;
|
||||
}
|
||||
|
||||
.superset-legacy-chart-partition g text {
|
||||
font-weight: ${theme.fontWeightStrong};
|
||||
fill: ${theme.colorText};
|
||||
}
|
||||
|
||||
.superset-legacy-chart-partition g:hover text {
|
||||
fill: ${theme.colorTextHeading};
|
||||
}
|
||||
|
||||
.superset-legacy-chart-partition .partition-tooltip {
|
||||
position: absolute;
|
||||
top: 0;
|
||||
left: 0;
|
||||
opacity: 0;
|
||||
padding: ${theme.sizeUnit}px;
|
||||
pointer-events: none;
|
||||
background-color: ${theme.colorBgElevated};
|
||||
border-radius: ${theme.borderRadius}px;
|
||||
}
|
||||
|
||||
.partition-tooltip td {
|
||||
padding-left: ${theme.sizeUnit}px;
|
||||
font-size: ${theme.fontSizeSM}px;
|
||||
color: ${theme.colorTextSecondary};
|
||||
}
|
||||
`}
|
||||
`;
|
||||
Reference in New Issue
Block a user