QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-20 00:24:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore(frontend): comprehensive TypeScript quality improvements (#37625)

Browse Source 
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Evan Rusackas
2026-02-06 16:16:57 -05:00
committed by GitHub
parent e9ae212c1c
commit fc5506e466
441 changed files with 14136 additions and 9956 deletions
Download Patch File Download Diff File Expand all files Collapse all files

74
superset-frontend/plugins/legacy-plugin-chart-world-map/test/WorldMap.test.ts
View File

@@ -18,7 +18,45 @@
*/
import d3 from 'd3';
import { getNumberFormatter, ValueFormatter } from '@superset-ui/core';
import WorldMap from '../src/WorldMap';
import { ColorBy } from '../src/utils';
interface WorldMapDataEntry {
country: string;
code: string;
latitude: number;
longitude: number;
name: string;
m1: number;
m2: number;
}
interface WorldMapProps {
countryFieldtype: string;
entity: string;
data: WorldMapDataEntry[];
width: number;
height: number;
maxBubbleSize: number;
showBubbles: boolean;
linearColorScheme: string;
color: string;
colorBy: ColorBy;
colorScheme: string;
sliceId: number;
theme: Record<string, unknown>;
onContextMenu: (
x: number,
y: number,
payload: Record<string, unknown>,
) => void;
setDataMask: (dataMask: Record<string, unknown>) => void;
inContextMenu: boolean;
filterState: { selectedValues?: string[] };
emitCrossFilters: boolean;
formatter: ValueFormatter;
}
type MouseEventHandler = (this: HTMLElement) => void;
@@ -56,12 +94,28 @@ jest.mock('datamaps/dist/datamaps.all.min', () => {
});
let container: HTMLElement;
const mockFormatter = jest.fn(val => String(val));
const formatter = getNumberFormatter();
const baseProps = {
const baseProps: WorldMapProps = {
data: [
{ country: 'USA', name: 'United States', m1: 100, m2: 200, code: 'US' },
{ country: 'CAN', name: 'Canada', m1: 50, m2: 100, code: 'CA' },
{
country: 'USA',
name: 'United States',
m1: 100,
m2: 200,
code: 'US',
latitude: 37.0902,
longitude: -95.7129,
},
{
country: 'CAN',
name: 'Canada',
m1: 50,
m2: 100,
code: 'CA',
latitude: 56.1304,
longitude: -106.3468,
},
],
width: 600,
height: 400,
@@ -69,7 +123,7 @@ const baseProps = {
showBubbles: false,
linearColorScheme: 'schemeRdYlBu',
color: '#61B0B7',
colorBy: 'country',
colorBy: ColorBy.Country,
colorScheme: 'supersetColors',
sliceId: 123,
theme: {
@@ -85,7 +139,7 @@ const baseProps = {
inContextMenu: false,
filterState: { selectedValues: [] },
emitCrossFilters: false,
formatter: mockFormatter,
formatter,
};
beforeEach(() => {
@@ -143,7 +197,7 @@ test('stores original fill color on mouseover', () => {
selectAll: jest.fn().mockReturnValue({ remove: jest.fn() }),
};
jest.spyOn(d3, 'select').mockReturnValue(mockD3Selection as any);
jest.spyOn(d3 as any, 'select').mockReturnValue(mockD3Selection as any);
// Capture the mouseover handler
mockSvg.on.mockImplementation((event: string, handler: MouseEventHandler) => {
@@ -198,7 +252,7 @@ test('restores original fill color on mouseout for country with data', () => {
selectAll: jest.fn().mockReturnValue({ remove: jest.fn() }),
};
jest.spyOn(d3, 'select').mockReturnValue(mockD3Selection as any);
jest.spyOn(d3 as any, 'select').mockReturnValue(mockD3Selection as any);
// Capture the mouseout handler
mockSvg.on.mockImplementation((event: string, handler: MouseEventHandler) => {
@@ -254,7 +308,7 @@ test('restores default fill color on mouseout for country with no data', () => {
selectAll: jest.fn().mockReturnValue({ remove: jest.fn() }),
};
jest.spyOn(d3, 'select').mockReturnValue(mockD3Selection as any);
jest.spyOn(d3 as any, 'select').mockReturnValue(mockD3Selection as any);
mockSvg.on.mockImplementation((event: string, handler: MouseEventHandler) => {
if (event === 'mouseout') {
@@ -296,7 +350,7 @@ test('does not handle mouse events when inContextMenu is true', () => {
selectAll: jest.fn().mockReturnValue({ remove: jest.fn() }),
};
jest.spyOn(d3, 'select').mockReturnValue(mockD3Selection as any);
jest.spyOn(d3 as any, 'select').mockReturnValue(mockD3Selection as any);
mockSvg.on.mockImplementation((event: string, handler: MouseEventHandler) => {
if (event === 'mouseover') {